store: properly handle disabled deltas
Metadata
Current evaluation
Merged #2181 in commit 5437f01ca, restoring HTTP 501 handling for disabled store deltas and adding regression tests for LP #1780851.
Resolution: closed resolved
Reason: PR #2181 was merged, resolving the regression in delta uploads when deltas are disabled. Commit 5437f01ca restores proper handling of HTTP 501 responses and adds coverage for the fix.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
In 2.41, the snapcraft CLI properly handled the situation of deltas being disabled on the store, which returned a 501. However, there was no test for this, which means as of 2.42.1, the behavior has regressed. This PR fixes [LP: #1780851](https://bugs.launchpad.net/snapcraft/+bug/1780851) by by properly handling 501s when pushing deltas.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2181 in commit 5437f01ca, restoring HTTP 501 handling for disabled store deltas and adding regression tests for LP #1780851. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2181 in commit 5437f01ca, restoring HTTP 501 handling for store-disabled deltas and adding regression coverage for LP #1780851. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2181 via commit 5437f01ca, restoring HTTP 501 handling for disabled deltas and adding regression tests for LP: #1780851. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for a regression where disabled deltas returning HTTP 501 were mishandled during push. Added regression tests, resolving LP: #1780851. Approved, passed CI, and achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Fixes a regression by properly handling HTTP 501 responses when the store disables deltas during push operations. Includes unit tests and increases code coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1780851 trying to upload a delta if delta service is disabled fails | snapcraft (launchpad) | closed | Fixed by merged PR #2181 (commit 5437f01ca), restoring fallback to a full-snap upload when the Store rejects deltas with HTTP 501. |