← Back to issue list

build providers: inject the base for classic

View original Github issue

Metadata

Project
snapcraft
Number
#2261
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Successfully merged pull request that injects the base snap for classic confinement to configure appropriate linker paths during builds. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

Inject the base snap building against if we are doing classic confinmenent to get the appropriate linker paths. LP: #1791938 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Successfully merged pull request that injects the base snap for classic confinement to configure appropriate linker paths during builds. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged changes to inject the base snap for classic confinement builds, resolving linker path issues and addressing LP: #1791938.
qwen3.6-35b-a3b-mtp-q6 Merged. Injects the base snap for classic confinement to configure appropriate linker paths during the build process, resolving LP #1791938.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#949 project: support building classic snaps snapcraft merged Added support for building classic snaps by configuring core snap paths. Reviewer feedback on architecture-specific linker paths was addressed, and the changes were approved and merged into master.
74%
#2394 build providers: fix osx non base and injection snapcraft merged Merged fix for macOS build provider non-base and injection issues. Approved by one reviewer, passed CI, and updated five files to resolve SNAPCRAFT-78, SNAPCRAFT-7A, and Launchpad bug 1801965.
74%
#2174 build_providers: inject snaps when running from a snap snapcraft merged Merged. Updates build providers to inject snapcraft and its base from the host when running inside the snapcraft snap, ensuring parity with non-snap environments. Approved by reviewer and passed CI checks.
74%
#3087 meta: remove snapd workaround for classic for core20 onwards snapcraft merged Removed snapd classic confinement workaround for core20 and newer bases. Retained command-chain workaround for core, core16, core18, and no base. Merged after single reviewer approval and passing CI checks.
72%
#2773 build providers: inject snapd snap for latest feature availability snapcraft merged Merged changes that inject the snapd snap into build providers instead of core, improving feature availability and reducing size. Approved by reviewer, passed CI, and modified 4 files (+59/-12 lines).
72%
#3146 build providers: snap sw to channels if injecting snapcraft merged Merged fix that prevents automatic channel switching to latest/stable when injecting snaps with revision assertions during build provider setup. Approved by reviewer, passed CI, and integrated.
72%
#997 feat(Provider): inject the base snap craft-application merged Merged. Injects the base snap into the provider alongside the application, eliminating separate downloads. Resolves #952 and CRAFT-4889. Approved by two reviewers with all CI checks passing.
71%
#2621 build providers: support injection for LXD snapcraft merged Merged after approval and passing CI. Implements LXD injection support via snapd's new file API, removes legacy mounts, and refactors code for better separation of concerns across 12 files.
71%
#3180 build providers: nice message on bad base snapcraft merged Merged implementation adding a new exception to handle invalid bases in LXD build providers, providing clearer error messages. Resolves SNAPCRAFT-1H2. Approved by one reviewer, passed CI, and modified 4 files (+77/-14).
71%