← Back to issue list

meta: friendlier message for incorrect app command

View original Github issue

Metadata

Project
snapcraft
Number
#2272
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#2272 (65ba888da), adding a clearer missing app-command error and a warning for commands not relative to the prime directory.

Resolution: closed resolved

Reason: The approved PR was merged as commit 65ba888da, implementing both the friendlier invalid-app-command error and prime-directory warning.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Provide a nicer error for when the command entires under an specific application cannot be found. Also, for future proofing, ensure a warning is raised when these commands are not relative to the prime directory. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#2272 (65ba888da), adding a clearer missing app-command error and a warning for commands not relative to the prime directory.
stealth/space-bunny-alpha — closed resolved Merged #2272 as 65ba888da, adding a clearer error for missing app command entries and warning when commands are not relative to the prime directory.
stealth/space-bunny-alpha — closed resolved Merged #2272 (commit 65ba888da), adding a friendlier error for missing app command entries and warning when commands are not relative to the prime directory.
stealth/space-bunny-alpha — closed resolved Merged PR #2272 (65ba888da) added a friendlier error for missing app commands and a warning for commands not relative to the prime directory.
qwen/qwen3.6-35b-a3b — — Merged changes that provide friendlier error messages for missing application commands and warn when commands are not relative to the prime directory. Approved by one reviewer, passed CI, and modified four files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Improves error messaging for missing application commands and adds a warning when commands are not relative to the prime directory.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3321 meta: add error check for "command not found" snapcraft merged Merged in snapcraft#3321 via commit 44930f709: missing app commands now raise InvalidAppCommandNotFound; PrimedCommandNotFoundError was removed and unit tests added.
78%
#1791175 check for the existence of a command snapcraft (launchpad) closed Missing app-command validation received a clearer error in merged PR snapcraft#2272, committed as 65ba888da.
73%
#1550496 Error message when command can't be found/isn't executable is terrible snapcraft (launchpad) closed Replaced the opaque shell failure with a clear missing-command error; fixed by canonical/snapcraft#350 via commit 23e598149.
72%
#3396 snap: address snapcraft warnings for app command snapcraft merged Merged PR #3396 as commit 524dd9811, applying a one-line fix to address Snapcraft warnings for the app command.
72%