meta: put environment into runner instead of app wrapper
Metadata
Current evaluation
Merged #2291, moving plugin environment and runnables from per-app wrappers into a dedicated runner; resolved LP #1794261 in commit e0f567833.
Resolution: closed resolved
Reason: PR #2291 was approved and merged into master as commit e0f567833. It implemented the runner extraction and resolved LP #1794261.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Currently, the snapcraft CLI takes the environment and runnables from plugins and shoves them into a wrapper per app. In anticipation of moving to command-chain, this PR resolves [LP: #1794261](https://bugs.launchpad.net/snapcraft/+bug/1794261) by extracting this information into a separate script, leaving the app wrappers as bare-bones as possible.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2291, moving plugin environment and runnables from per-app wrappers into a dedicated runner; resolved LP #1794261 in commit e0f567833. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2291, moving plugin environment setup and runnables from per-app wrappers into a dedicated runner script ahead of command-chain support; resolves LP: #1794261. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Extracts environment and runnables from app wrappers into a dedicated runner script to prepare for command-chain migration. Resolves LP: #1794261. Approved and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Extracts environment and runnables into a dedicated runner script instead of per-app wrappers, resolving LP: #1794261 and preparing for command-chain migration. Passed static and unit tests with 95.83% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1794261 Put environment in command-chain instead of the opaque wrapper | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#2291 (commit e0f567833), moving plugin environments and runnables from opaque per-app wrappers into a dedicated runner. |