← Back to issue list

meta: put environment into runner instead of app wrapper

View original Github issue

Metadata

Project
snapcraft
Number
#2291
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged. Extracts environment and runnables from app wrappers into a dedicated runner script to prepare for command-chain migration. Resolves LP: #1794261. Approved and passed CI checks.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Currently, the snapcraft CLI takes the environment and runnables from plugins and shoves them into a wrapper per app. In anticipation of moving to command-chain, this PR resolves [LP: #1794261](https://bugs.launchpad.net/snapcraft/+bug/1794261) by extracting this information into a separate script, leaving the app wrappers as bare-bones as possible.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Extracts environment and runnables from app wrappers into a dedicated runner script to prepare for command-chain migration. Resolves LP: #1794261. Approved and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Extracts environment and runnables into a dedicated runner script instead of per-app wrappers, resolving LP: #1794261 and preparing for command-chain migration. Passed static and unit tests with 95.83% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Extracts environment and runnables from app wrappers into a dedicated runner script to prepare for command-chain migration, resolving LP: #1794261. Diff coverage achieved 95.83%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1794261 Put environment in command-chain instead of the opaque wrapper snapcraft (launchpad) closed Closed and implemented as part of the command-chain migration. Environment configuration was moved to a separate binary, replacing the opaque wrapper approach for snapcraft applications.
71%