← Back to issue list

project loader: remove remote parts support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2304
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2304 as commit 06532fe0c, removing remote-part support for bases, rejecting invalid `after` parts, and dropping the update/search/define CLI commands.

Resolution: closed resolved

Reason: PR #2304 was merged into master as commit 06532fe0c. It removed remote-part loading for bases and added errors for undefined `after` parts or part definitions without plugins.

Evaluated by: mr-cal-bot

No scores available.

Issue body

When using bases, the project loader should error out on parts that attempt to use after with a part not locally defined or a part definition which does not specify a plugin. Additionally, given the re-exec logic, remove update, search and define from the cli. LP: #1794805 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2304 as commit 06532fe0c, removing remote-part support for bases, rejecting invalid `after` parts, and dropping the update/search/define CLI commands.
stealth/space-bunny-alpha — closed resolved Merged PR #2304 (commit 06532fe0c) removed remote-part support for bases, rejecting undefined after-parts or missing plugins, and removed CLI update, search, and define commands.
stealth/space-bunny-alpha — closed resolved Merged #2304 via commit 06532fe0c: removed remote-parts support for bases and the update, search, and define commands.
qwen/qwen3.6-35b-a3b — — Merged removal of remote parts support for bases. The project loader now errors on undefined parts or missing plugins. CLI commands update, search, and define were removed. Approved and merged after passing CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged to master as PR #2304. The project loader now errors on remote parts and missing plugin definitions for bases. CLI commands update, search, and define were removed due to re-exec logic. Codecov confirmed 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2153 project_loader: allow loading null parts snapcraft merged Merged as commit 78cb692f5, allowing null-valued parts so remote parts can be listed without an artificial after dependency.
71%
#735 Load the remote parts only when needed. snapcraft merged Merged PR #735 (commit 25fbbe8ef) to defer loading remote parts until they are needed, avoiding unnecessary remote-part loading.
70%
#1804067 Remote part always considered 'pull step changed' after modifying files in local tree snapcraft (launchpad) closed Remote-part pull invalidation was not fixed; support for remote parts in base-based projects was later removed by PR #2304 (commit 06532fe0c).
70%