nodejs plugin: add support for ppc64el and s390x
Metadata
Current evaluation
Merged PR #2310 (commit 6261dba9c) added ppc64el and s390x to the nodejs plugin's supported architectures, resolving LP bug #1795531; backported to 2.x via merged PR #2314.
Resolution: closed resolved
Reason: The PR was approved by sergiusens and merged as commit 6261dba9c "nodejs plugin: add support for ppc64el and s390x (#2310)", which extended the nodejs plugin architecture list (+8/-1 lines in snapcraft/plugins/nodejs.py). A backport PR #2314 was also merged, and the linked Launchpad bug #1795531 is now closed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1795531
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] (N/A) If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
The addition of the ppc64el and s390x to the list of nodejs plugin supported architectures has been tested with custom plugin x-nodejs to work with auto-building Hugo snaps Launchpad, see:
* Temporary workaround with x-nodejs plugin https://github.com/gohugoio/hugo/commit/91f49c0700dde13e16f42c745584a0bef60c6fe2 (Line 68)
* https://launchpad.net/~gohugoio/+snap/hugo
* Successful s390x buildlog: https://launchpadlibrarian.net/391166164/buildlog_snap_ubuntu_xenial_s390x_hugo_BUILDING.txt.gz
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2310 (commit 6261dba9c) added ppc64el and s390x to the nodejs plugin's supported architectures, resolving LP bug #1795531; backported to 2.x via merged PR #2314. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2310 as commit 6261dba9c, adding ppc64el and s390x support to the Node.js plugin after successful s390x Hugo builds. | |
| qwen/qwen3.6-35b-a3b | — | — | Added ppc64el and s390x architecture support to the nodejs plugin. Approved, passed CI, and merged to resolve Launchpad bug #1795531. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added ppc64el and s390x architecture support to the nodejs plugin. Changes were validated through successful Hugo snap builds on Launchpad and approved by maintainers. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
snapcraft#2314
(confidence 85%)
Merged backport PR carrying the same nodejs plugin ppc64el/s390x support into the 2.x branch.
-
Duplicate Of:
snapcraft#2314
(confidence 80%)
Backport of #2310 into the 2.4x series; same commit 6261dba9c referenced.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2314 nodejs plugin: add support for ppc64el and s390x (#2310) (#2310) | snapcraft | merged | Merged PR #2314, backporting #2310: added ppc64el and s390x support to Snapcraft's Node.js plugin in commit 6261dba9c. | |
| #1795531 nodejs plugin support for ppc64el and s390x architectures | snapcraft (launchpad) | closed | Added ppc64el and s390x support to the Node.js plugin in merged PR canonical/snapcraft#2310 (commit 6261dba9c); PR #2314 backported it to Snapcraft 2.x. | |
| #118 nodejs plugin: support 32 bit node | snapcraft | merged | Merged #118 via commit 05888706a, adding 32-bit Node.js support to the nodejs plugin for Trusty package builds. |