← Back to issue list

pluginhandler: remove big solidus workaround

View original Github issue

Metadata

Project
snapcraft
Number
#2330
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged removal of the forward slash workaround in pluginhandler, now that bases eliminate wiki parts and allow forbidding slashes in part names. Approved by one reviewer, passed CI, and achieved 100% diff coverage across seven files. Resolves LP #1796723.

Suggested action:

No scores available.

Issue body

With bases, wiki parts are gone so part names with forward slashes can now be forbidden. LP: #1796723 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged removal of the forward slash workaround in pluginhandler, now that bases eliminate wiki parts and allow forbidding slashes in part names. Approved by one reviewer, passed CI, and achieved 100% diff coverage across seven files. Resolves LP #1796723.
qwen3.6-35b-a3b-mtp-q6 Merged. Removed the forward slash workaround in pluginhandler since bases replaced wiki parts, allowing part names with slashes to be forbidden. Codecov reported 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the forward slash workaround in pluginhandler. With wiki parts deprecated, part names containing slashes are now forbidden. The change achieved 100% diff coverage and was integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1405 pluginhandler: check for collisions only in existing files snapcraft merged Merged to resolve Launchpad bug #1660696 by updating the pluginhandler to check for collisions only in existing files. Approved by two reviewers, the change modifies six files with 45 additions and 4 deletions.
71%