pluginhandler: remove big solidus workaround
Metadata
Current evaluation
Merged PR #2330 as commit f83720ad6, removing pluginhandler’s solidus workaround and forbidding forward slashes in part names after wiki parts were removed (LP #1796723).
Resolution: closed resolved
Reason: The approved PR was merged as commit f83720ad6. It removed the obsolete solidus workaround and added validation rejecting part names containing forward slashes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
With bases, wiki parts are gone so part names with forward
slashes can now be forbidden.
LP: #1796723
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2330 as commit f83720ad6, removing pluginhandler’s solidus workaround and forbidding forward slashes in part names after wiki parts were removed (LP #1796723). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2330 removed pluginhandler's solidus workaround and forbade slash-containing part names now that wiki parts are gone; resolving commit f83720ad6 (LP #1796723). | |
| stealth/space-bunny-alpha | — | closed resolved | Removed pluginhandler’s solidus workaround and forbade forward slashes in part names after wiki parts disappeared. Merged as commit f83720ad6 via PR #2330, fixing LP #1796723. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of the forward slash workaround in pluginhandler, now that bases eliminate wiki parts and allow forbidding slashes in part names. Approved by one reviewer, passed CI, and achieved 100% diff coverage across seven files. Resolves LP #1796723. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed the forward slash workaround in pluginhandler since bases replaced wiki parts, allowing part names with slashes to be forbidden. Codecov reported 100% diff coverage. |
Update history
No update history recorded yet.
Related work
-
Caused By:
launchpad#1796723
(confidence 95%)
The PR identifies LP #1796723 as the motivating bug.
Related issues
No related issues found above the similarity threshold.