← Back to issue list

meson plugin: add support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2331
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2331 (commit 1e19e86a6) revamped the Meson plugin to be base-aware and to install Meson from PyPI instead of system apt repos, resolving LP bug #1794794.

Resolution: closed resolved

Reason: The PR was approved and merged into master as commit 1e19e86a6 ("meson plugin: add support for bases (#2331)"), with +213/-25 lines across 9 files. It adds base-aware property handling and PyPI-based Meson provisioning in snapcraft/plugins/meson.py; later commits e1cc2b91c and e3b3b8870 further refined base detection for the plugin.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Revamp the meson plugin to be base aware. Install meson straight from PyPI instead of from the system's repositories. LP: #1794794 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2331 (commit 1e19e86a6) revamped the Meson plugin to be base-aware and to install Meson from PyPI instead of system apt repos, resolving LP bug #1794794.
stealth/space-bunny-alpha — closed resolved Merged snapcraft#2331 in commit 1e19e86a6, making the Meson plugin base-aware and installing Meson from PyPI instead of system repositories.
stealth/space-bunny-alpha — closed resolved Merged PR #2331 (commit 1e19e86a6), making the Meson plugin base-aware and installing Meson from PyPI instead of system repositories.
qwen/qwen3.6-35b-a3b — — Merged changes revamping the meson plugin to support bases, switching meson installation from system repositories to PyPI. Approved by reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged the meson plugin update to support bases. The plugin now installs meson directly from PyPI instead of system repositories, resolving LP #1794794. Changes achieved 95.83% diff coverage.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2499 (confidence 60%)

    Commit e1cc2b91c added support for "base: core" and touched the base-aware plugin property handling that #2331 introduced.

  • Related To: snapcraft#1294 (confidence 45%)

    Commit 0a62dc065 originally added the Meson plugin, which #2331 later revamped for base support.

Related issues

Issue Project State Summary Similarity
#1294 meson plugin: Add plugin for meson build system snapcraft merged Merged into master via PR #1294 (commit 0a62dc065), adding Meson build-system support; build options can be supplied through meson-parameters.
76%
#1794794 Update the meson plugin to be base aware snapcraft (launchpad) closed Meson plugin was made base-aware by merged PR snapcore/snapcraft#2331, commit 1e19e86a6.
76%
#180 plugins: add meson plugin craft-parts merged Merged PR #180 added Meson plugin support and fixed out-of-source-build handling. Changes landed in commit 228706de and were merged as a48ad0b9.
74%
#725 docs: document the Meson plugin craft-parts merged Merged PR #725, commit d7eb19d1, added Meson plugin reference documentation, changing three files with 74 additions and one deletion.
71%
#1653128 support the Meson build system snapcraft (launchpad) closed Meson build support was added by merged PR #1294 in commit 0a62dc065, including configurable meson-parameters.
71%