← Back to issue list

nodejs plugin: update to the latest 8.x LTS version

View original Github issue

Metadata

Project
snapcraft
Number
#2342
Type
pull request
State
merged
Author
anthonyfok
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2342 updated Snapcraft's nodejs plugin to the latest Node.js 8.x LTS release in commit b847e74af.

Resolution: closed resolved

Reason: PR #2342 was approved and merged into master. Commit b847e74af records the nodejs plugin version update.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1797374 - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Thanks!

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2342 updated Snapcraft's nodejs plugin to the latest Node.js 8.x LTS release in commit b847e74af.
stealth/space-bunny-alpha — closed resolved Merged #2342 updates the nodejs plugin to the latest Node.js 8.x LTS version; commit b847e74af landed in master.
qwen/qwen3.6-35b-a3b — — Merged into master. Updated the nodejs plugin to the latest 8.x LTS version. The change was approved, passed CI, and modified a single file with a two-line diff. Code coverage increased marginally.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master, updating the nodejs plugin to the latest 8.x LTS version. The change passed all tests, achieved 100% diff coverage, and resolves Launchpad bug #1797374.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1797374 Update nodejs plugin to use latest LTS version 8.12.0 snapcraft (launchpad) closed Updated Snapcraft's Node.js plugin default to 8.12.0 via merged PR snapcraft#2342, commit b847e74af.
92%
#2001 node-engine does not support NodeJS 8.X.X snapcraft closed Closed as stale; later PR #2342 updated Snapcraft's Node.js plugin to the latest 8.x LTS in commit b847e74af.
82%
#1772126 Update default nodejs version snapcraft (launchpad) closed Default nodejs plugin version bumped from 6.11.4 to the latest 6.x LTS (6.14.2) by snapcore/snapcraft PR #2157, commit 4b6636621; maintainer linked the PR and the Launchpad bug was closed.
78%
#2157 nodejs plugin: update to the latest 6.x LTS point release snapcraft merged Merged in PR #2157 via commit 4b663662, updating the Node.js plugin to the latest 6.x LTS point release.
78%
#1755524 Can not use NodeJS 8 snapcraft (launchpad) closed Closed as stale; Node.js 8 support was later addressed in snapcraft#2342 which updated the nodejs plugin to the latest 8.x LTS.
77%
#1794796 Update the nodejs plugin to be base aware snapcraft (launchpad) closed Base-aware Node.js plugin support was merged in snapcore/snapcraft#2356 via commit 3465f984f, covering the npm/yarn plugin work requested by the issue.
72%
#1232 nodejs plugin: switch to the newer LTS. (#1228) snapcraft merged Merged as commit 41fb68bb5, updating the Node.js plugin from unavailable 6.10.1 to 6.10.2 and backporting the correction from #1228.
71%