← Back to issue list

extensions: remove root extensions

View original Github issue

Metadata

Project
snapcraft
Number
#2348
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged removal of root extension declarations from snapcraft.yaml. Resolves LP #1797631 by deferring application scope decisions until usage patterns clarify. Approved by maintainer, passed CI, and modified two files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- It's not clear how root extensions should be applied: to all apps? To apps that don't declare their own extensions? This PR resolves [LP: #1797631](https://bugs.launchpad.net/snapcraft/+bug/1797631) by holding off on that decision until we see how extensions are used, and removing the ability to declare extensions in the root for now.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged removal of root extension declarations from snapcraft.yaml. Resolves LP #1797631 by deferring application scope decisions until usage patterns clarify. Approved by maintainer, passed CI, and modified two files.
qwen3.6-35b-a3b-mtp-q6 Root extension declarations removed from snapcraft.yaml to resolve ambiguity regarding their application scope. Implementation deferred until usage patterns clarify behavior, addressing LP: #1797631. Merged with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged removal of root-level extension declarations to resolve LP: #1797631. The feature was temporarily disabled due to unclear application scope, deferring implementation until usage patterns emerge. Changes achieved 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2347 extensions: support adding root properties snapcraft merged Merged: extensions can now add YAML snippets to the root of snapcraft.yaml, resolving LP: #1794531. Approved by a reviewer, passed CI with 100% diff coverage, and modified three files.
78%
#4110 extensions: parse snapcraft.yaml before expanding extensions snapcraft merged Merged fix for the expand-extensions command to parse snapcraft.yaml before expanding extensions. Resolves core22 parsing issues with parse-info and advanced grammar keywords. Approved, passed CI, and merged into main.
75%
#292 extensions: add cli commands rockcraft merged Merged addition of list-extensions and expand-extensions CLI commands matching Snapcraft semantics, plus test refactoring. Resolves #274. Approved by two reviewers, passed CI, and modified 15 files (+452/-109 lines).
74%
#1797631 Remove root extensions property snapcraft (launchpad) closed Resolved by removing the root extensions property to eliminate ambiguity regarding its behavior and interaction with app extensions. The change prevents breaking existing configurations until consensus is reached.
72%
#2349 extensions: use extension docstring snapcraft merged Merged into master. Replaces the generic snapcraft extension description with extension-specific docstrings, resolving bug LP: #1797655. Approved by reviewer and passed all CI checks.
72%
#885 fix: Removed reference to snapcraft.yaml in expand extensions rockcraft open One-line fix removing the snapcraft.yaml reference from the expand-extensions help text and docstring, fixing #658. Approved by 2 reviewers with all CI checks green, but unmerged and inactive ~6 months; the fix is still unapplied in the codebase.
72%
#2355 extensions: cleanup and generic tests snapcraft merged Resolved LP: #1791172 by ensuring extensions are properly installable and adding generic smoke tests for future extensions. Merged after approval and passing CI, modifying 10 files (+133/-17).
72%
#1103 fix: remove snapcraft.yaml reference from expand-extensions rockcraft open Removes snapcraft.yaml references from expand-extensions help text and docstring (3 lines, 1 file). Approved with CI green, but inactive ~6 months; fix still unapplied in codebase; likely duplicate of older PR #885.
72%
#3679 Expand extensions snapcraft merged Merged into snapcraft/7.0 after approval and passing CI checks. The changes expand extensions, address CRAFT-948, and increased overall coverage by 0.17%.
71%
#2350 extensions: parse all declared extensions before applying snapcraft merged Merged to resolve LP: #1797638 by parsing all declared extensions before applying them, fixing conflicts when multiple apps share an extension. Approved, passed CI, and achieved 100% diff coverage.
71%