← Back to issue list

Preflight missing multipass

View original Github issue

Metadata

Project
snapcraft
Number
#2354
Type
pull request
State
merged
Author
evandandrea
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2354 added a preflight check and install prompt for missing Multipass when building base-keyword snaps, fixing Launchpad bug #1792374.

Resolution: closed resolved

Reason: PR #2354 was approved, manually verified, and merged. Commit e494b9339 records the missing-Multipass checks and installation prompt.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- Fixes https://bugs.launchpad.net/snapcraft/+bug/1792374 Feedback welcome on structure. @sergiusens suggested asking to install multipass further up, but it's not clear to me where. A decorator on the lifecycle functions?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2354 added a preflight check and install prompt for missing Multipass when building base-keyword snaps, fixing Launchpad bug #1792374.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#2354 via commit e494b9339, adding a preflight prompt to install Multipass when building snaps that use the base keyword.
stealth/space-bunny-alpha — closed resolved Merged #2354 as commit e494b9339, adding a preflight check that prompts users to install Multipass when building snaps that use the base keyword.
stealth/space-bunny-alpha — closed resolved Merged PR #2354, fixing Launchpad bug #1792374 by prompting users to install missing Multipass before building snaps that use the base keyword.
stealth/space-bunny-alpha — closed resolved Merged PR #2354 fixed Launchpad bug #1792374 by preflighting missing Multipass, prompting installation before building snaps that use base.
qwen/qwen3.6-35b-a3b — — Merged fix for bug #1792374 adding a preflight check to prompt multipass installation when building snaps with the base keyword. Approved by reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged to fix bug #1792374 by adding a preflight check for missing multipass. The update prompts users to install multipass before building snaps requiring the base keyword, with maintainer review confirming successful functionality.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.