← Back to issue list

cli: consolidate re-execution

View original Github issue

Metadata

Project
snapcraft
Number
#2385
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2385 in commit 404255671, consolidating CLI re-execution under one console_scripts entry and leaving root handling to Multipass build-provider APIs.

Resolution: closed resolved

Reason: PR #2385 was merged as commit 404255671, consolidating duplicate re-execution logic and delegating root-user handling to Multipass's build-provider implementation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Re-execution was done in two locations, minimize that by moving the re-execution logic back into a console_scripts entry and leaving the root user handling to multipass' implementation of the build provider APIs. LP: #1795680 LP: #1799780 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2385 in commit 404255671, consolidating CLI re-execution under one console_scripts entry and leaving root handling to Multipass build-provider APIs.
stealth/space-bunny-alpha — closed resolved Merged PR #2385 in commit 404255671, consolidating CLI re-execution into one console_scripts entry and delegating root-user handling to Multipass build provider APIs.
qwen/qwen3.6-35b-a3b — — Merged after consolidating CLI re-execution logic into a single console_scripts entry, resolving Launchpad bugs #1795680 and #1799780. A reviewer noted a minor file ownership quirk in debug mode, but the changes passed CI and were approved.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Consolidated CLI re-execution logic into a console_scripts entry, delegating root user handling to Multipass APIs. Resolves LP #1795680 and #1799780. Verified by maintainer during review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1795680 Consolidate root execution with legacy re-execution snapcraft (launchpad) closed Fixed by canonical/snapcraft#2385 (commit 404255671), consolidating root and legacy re-execution through one CLI entry point and provider root handling.
74%
#1799780 root user handling for multipass is confusing snapcraft (launchpad) closed Fixed by merged snapcore/snapcraft#2385 (commit 404255671), consolidating CLI re-execution and delegating Multipass root handling to build-provider APIs.
73%