← Back to issue list

cli: consolidate re-execution

View original Github issue

Metadata

Project
snapcraft
Number
#2385
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after consolidating CLI re-execution logic into a single console_scripts entry, resolving Launchpad bugs #1795680 and #1799780. A reviewer noted a minor file ownership quirk in debug mode, but the changes passed CI and were approved.

Suggested action:

No scores available.

Issue body

Re-execution was done in two locations, minimize that by moving the re-execution logic back into a console_scripts entry and leaving the root user handling to multipass' implementation of the build provider APIs. LP: #1795680 LP: #1799780 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after consolidating CLI re-execution logic into a single console_scripts entry, resolving Launchpad bugs #1795680 and #1799780. A reviewer noted a minor file ownership quirk in debug mode, but the changes passed CI and were approved.
qwen3.6-35b-a3b-mtp-q6 Merged. Consolidated CLI re-execution logic into a console_scripts entry, delegating root user handling to Multipass APIs. Resolves LP #1795680 and #1799780. Verified by maintainer during review.
qwen3.6-35b-a3b-mtp-q6 Merged. Consolidates CLI re-execution into a console_scripts entry and delegates root handling to multipass APIs. Fixes LP #1795680 and #1799780. A minor debug mode ownership quirk was noted but did not block the merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#433 Converge all commands into one snapcraft merged Merged a refactor that consolidates multiple commands into one, addressing Launchpad bugs #1567058 and #1567041. The change touches 35 files and removes over 1000 lines of code to eliminate redundant, interdependent logic.
71%