← Back to issue list

python plugin: process deps before and separately from setup.py

View original Github issue

Metadata

Project
snapcraft
Number
#2409
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2409 in commit 6c8cb57b4, separating dependency processing from setup.py handling and excluding setup.py from the download phase.

Resolution: closed resolved

Reason: The approved PR was merged as commit 6c8cb57b4, resolving the setup.py dependency-processing problem tracked by LP #1803573.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This change ensures that if setup.py has a dependency in order to be processed that it can be handled by processing dependencies separately followed by the handling of setup.py. for increased cleanup, setup.py does not form part of the "download" process. LP: #1803573 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2409 in commit 6c8cb57b4, separating dependency processing from setup.py handling and excluding setup.py from the download phase.
stealth/space-bunny-alpha — closed resolved Merged in #2409 as 6c8cb57b4: the Python plugin now processes dependencies before setup.py, with setup.py handled separately from downloads.
qwen/qwen3.6-35b-a3b — — Merged into master. Modifies the Python plugin to process dependencies separately before executing setup.py, excluding setup.py from the download phase. Approved by reviewer, passed CI, and resolves LP #1803573.
qwen3.6-35b-a3b-mtp-q6 — — Merged. The Python plugin now processes dependencies separately before running setup.py, excluding setup.py from downloads. This change resolves Launchpad bug #1803573 and improves build cleanup.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2771 python plugin: first try processing setup.py without PyPI snapcraft merged Merged in #2771 via commit 9bac0fd64: the Python plugin resolves setup.py dependencies from python-packages and requirements first, then falls back to PyPI.
74%
#1803573 setup.py with dependencies cannot be properly handled snapcraft (launchpad) closed Split setup.py handling so dependencies are processed first and separately from setup.py itself. Implemented in snapcraft PR #2409, merged as commit 6c8cb57b4 ("python plugin: process deps before and separately from setup.py").
72%