tools: pull in imporved cla_check.py from snapd
Metadata
Current evaluation
Merged in snapcraft#2415 as e32c871cc, replacing tools/cla_check.py with snapd's faster, clearer implementation.
Resolution: closed resolved
Reason: Pull request #2415 was merged as commit e32c871cc. The new checker improved speed, accuracy, and output while allowing manual verification when contributor privacy prevents identification.
Evaluated by: mr-cal-bot
No scores available.
Issue body
We'll get to snap these sometime, but until then, here have the
cla_check.py we're using in snapd, based on yours (but much
improved). It's faster, more accurate, and has nicer, simpler, easier
to understand output.
Note that it does have an output of "I don't know", which still passes
the test. This can happen if a PR is done entirely using github's web
tools from a privacy-enabled account. You'd need to verify manually
then.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#2415 as e32c871cc, replacing tools/cla_check.py with snapd's faster, clearer implementation. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #2415 by chipaca merged as commit e32c871cc, replacing tools/cla_check.py with a faster, clearer port of snapd's version (+100/-43, 1 file). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2415 as commit e32c871cc, replacing cla_check.py with a faster, clearer version from snapd; unknown results still pass but require manual verification. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged an improved cla_check.py from snapd, enhancing speed, accuracy, and output clarity. Approved by one reviewer, the update replaces the original script in a single file change and handles edge cases like GitHub web tool submissions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged an improved cla_check.py script from snapd. The update provides faster execution, better accuracy, and clearer output. Despite a Codecov warning regarding missing base commit coverage, the changes were successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1503 ci: speedup the CLA check | snapcraft | merged | Merged in snapcraft#1503 (commit 22ef942d6), speeding CLA validation by checking each email once and skipping commits already in master. |