← Back to issue list

schema: allow before and after

View original Github issue

Metadata

Project
snapcraft
Number
#2443
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 8942bd69e, adding before/after schema fields and deferring most validation to snap pack; addresses LP #1808148.

Resolution: closed resolved

Reason: PR #2443 was approved and merged as commit 8942bd69e. The change permits before and after in the schema while relying on snap pack for most validation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Rely on most of the validation done by `snap pack`. LP: #1808148 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 8942bd69e, adding before/after schema fields and deferring most validation to snap pack; addresses LP #1808148.
stealth/space-bunny-alpha — closed resolved Merged #2443 as 8942bd69e, allowing before and after schema fields while deferring most validation to snap pack; addresses LP #1808148.
stealth/space-bunny-alpha — closed resolved Merged #2443 as commit 8942bd69e, adding before and after schema fields and deferring most validation to snap pack; addresses LP #1808148.
qwen/qwen3.6-35b-a3b — — Merged. Introduces before and after schema fields, relying on snap pack for validation. Approved by two reviewers, passed CI, and modified three files. Addresses LP: #1808148.
qwen3.6-35b-a3b-mtp-q6 — — Merged schema update permitting before and after fields, delegating validation to snap pack. Resolves LP #1808148. Approved and merged by maintainer following code review.

Update history

No update history recorded yet.

Related work

Related issues

No related issues found above the similarity threshold.