← Back to issue list

schema: allow before and after

View original Github issue

Metadata

Project
snapcraft
Number
#2443
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged. Introduces before and after schema fields, relying on snap pack for validation. Approved by two reviewers, passed CI, and modified three files. Addresses LP: #1808148.

Suggested action: —

No scores available.

Issue body

Rely on most of the validation done by `snap pack`. LP: #1808148 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged. Introduces before and after schema fields, relying on snap pack for validation. Approved by two reviewers, passed CI, and modified three files. Addresses LP: #1808148.
qwen3.6-35b-a3b-mtp-q6 — — Merged schema update permitting before and after fields, delegating validation to snap pack. Resolves LP #1808148. Approved and merged by maintainer following code review.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Schema now allows before and after fields, relying on snap pack for validation. Resolves Launchpad issue 1808148. Approved and merged by maintainer despite missing Codecov coverage upload.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2609 schema: allow 'snapd' snap type snapcraft merged Merged to allow the 'snapd' snap type in the schema. Approved by one reviewer, passed CI checks, and modified three files.
74%