← Back to issue list

baseplugin: add a proper exception for cross-compilation support

View original Github issue

Metadata

Project
snapcraft
Number
#2454
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged changes add a proper exception to notify users when cross-compilation is used with unsupported plugins. Approved, passed CI, and achieved 100% diff coverage. Resolves SNAPCRAFT-95, SNAPCRAFT-AQ, and LP: #1808454.

Suggested action:

No scores available.

Issue body

Add a proper exception to notify the user when cross compilation is used with parts using plugins that do not support it. Fixes SNAPCRAFT-95 Fixes SNAPCRAFT-AQ LP: #1808454 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes add a proper exception to notify users when cross-compilation is used with unsupported plugins. Approved, passed CI, and achieved 100% diff coverage. Resolves SNAPCRAFT-95, SNAPCRAFT-AQ, and LP: #1808454.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Adds an exception to notify users when cross-compilation is attempted with unsupported plugins, resolving SNAPCRAFT-95, SNAPCRAFT-AQ, and LP: #1808454.
qwen3.6-35b-a3b-mtp-q6 Merged. Introduces an exception to warn users when cross-compilation is used with unsupported plugins. Resolves SNAPCRAFT-95, SNAPCRAFT-AQ, and LP #1808454. Achieved 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1350 rust plugin: Add support for cross-compilation snapcraft merged Cross-compilation support added to the Rust plugin for snapcraft's --target-arch flag. Approved and merged despite unresolved comments and lack of ARM hardware testing.
72%
#3317 plugin handler: properly handle snapcraftctl errors snapcraft merged Merged fix for plugin handler to properly catch snapcraftctl errors. Replaced specific exception handling with a broad catch in the scriptlet runner to prevent silent failures and redundant output. Approved, passed CI, and increased coverage.
72%
#1349 plugins: clarify wording of cross-compilation unsupported error snapcraft merged Merged a change clarifying the cross-compilation unsupported error message. The update correctly states that the plugin lacks support instead of confusingly referencing the part name. Approved by one reviewer with zero comments.
71%