← Back to issue list

catkin plugin: describe how to build all packages

View original Github issue

Metadata

Project
snapcraft
Number
#2459
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 5f8c2061: adds the missing Catkin plugin doc blurb noting catkin-packages builds all workspace packages when unset, documenting the earlier LP: #1721168 fix (PR #1743, ec4cac26a).

Resolution: closed resolved

Reason: PR #2459 was merged into master as commit 5f8c2061, updating docs/reference/plugins/catkin_plugin.rst to state 'The Catkin packages to build. If unset, all packages in the workspace will be built.' The referenced functional fix was PR #1743 (commit ec4cac26a) for LP: #1721168, which made catkin-packages optional.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Add the documentation blurb left out of the fix for [LP: #1721168.](https://bugs.launchpad.net/snapcraft/+bug/1721168).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 5f8c2061: adds the missing Catkin plugin doc blurb noting catkin-packages builds all workspace packages when unset, documenting the earlier LP: #1721168 fix (PR #1743, ec4cac26a).
stealth/space-bunny-alpha — closed resolved Merged #2459 as 5f8c20615, adding missing catkin plugin documentation for building all workspace packages and documenting the fix for LP: #1721168.
qwen/qwen3.6-35b-a3b — — Merged a documentation update for the catkin plugin explaining how to build all packages. Adds a missing blurb from a previous bug fix. Approved by two reviewers, passed CI, and modified one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged documentation update for the catkin plugin detailing how to build all packages. Completes the fix for LP: #1721168 by adding previously omitted instructions. No code changes were made.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1743 (confidence 95%)

    Earlier merged PR that made catkin-packages optional so the Catkin plugin builds the whole workspace (commit ec4cac26a), resolving LP: #1721168; this PR documents that behaviour.

  • Likely Fixed By: snapcraft#1743 (confidence 80%)

    Underlying behavioural fix for the Launchpad bug referenced in the PR body.

Related issues

Issue Project State Summary Similarity
#1743 catkin plugin: support building entire workspace snapcraft merged Merged #1743 in commit ec4cac26a, making catkin-packages optional so the Catkin plugin builds the entire workspace when omitted; this also resolves snapcraft#1713.
80%
#1713 catkin plugin: support for building all packages in a given workspace snapcraft closed Implemented workspace-wide Catkin builds: omitting catkin-packages now builds every package. Merged in canonical/snapcraft#1743 via commit ec4cac26a.
79%
#1721168 Catkin plugin: support building the entire workspace snapcraft (launchpad) closed Implemented in snapcraft PR #1743 (commit ec4cac26a, "catkin plugin: support building entire workspace"), merged ~Nov 2017. catkin-packages became optional: omitting it builds the whole workspace, while an empty list still means no packages.
77%
#2585 catkin plugin: check workspace for dependencies snapcraft merged Merged PR #2585 (b88e37814) fixed Catkin builds by using rospack to enumerate workspace packages and exclude their internal dependencies from rosdep resolution; resolves LP #1832044.
70%