project loader: do not leak a part's build-environment
Metadata
Current evaluation
Merged #2472 as commit 8ca7dd7f2, preventing a part's build environment from leaking into parts declared with after and avoiding unintended concatenation.
Resolution: closed resolved
Reason: PR #2472 was approved and merged as commit 8ca7dd7f2, implementing the build-environment isolation fix.
Evaluated by: mr-cal-bot
No scores available.
Issue body
When using after, all components related to the environment get
concatenated when using after, that is not an intuitive behavior from a
user's point of view.
LP: #1815658
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2472 as commit 8ca7dd7f2, preventing a part's build environment from leaking into parts declared with after and avoiding unintended concatenation. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2472 in commit 8ca7dd7f2, preventing a part's build environment from leaking when using after and avoiding unintended concatenation. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix preventing build environment leakage when using after. Modifies three files (+10/-9 lines) to stop unintended concatenation, resolving Launchpad bug #1815658. Approved, passed CI, 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix preventing build-environment leakage when using the after directive in the project loader. Resolves Launchpad bug #1815658 with 100% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2322 project_loader: add build-environment part property | snapcraft | merged | Merged in snapcraft#2322 (commit d17b67d20), adding an ordered part-level build-environment property for lifecycle variables and resolving LP #1778174. | |
| #2146 project_loader: process parts in consistent order | snapcraft | merged | Merged #2146 as commit e3f327f88, sorting parts by name for deterministic project loading while honoring after prerequisites; fixes LP #1759875. | |
| #2153 project_loader: allow loading null parts | snapcraft | merged | Merged as commit 78cb692f5, allowing null-valued parts so remote parts can be listed without an artificial after dependency. | |
| #2744 project_loader: load build-environment after snapcraft environment | snapcraft | merged | Merged PR #2744 (commit f3799a5dc) reordered project-loader evaluation so build-environment loads after Snapcraft's environment, enabling variables such as $SNAPCRAFT_PART_INSTALL. |