← Back to issue list

snapcraft/extractors/setuppy.py: match setuptools metadata keys

View original Github issue

Metadata

Project
snapcraft
Number
#2518
Type
pull request
State
closed
Author
anonymouse64
Labels
Created
Updated
Closed

Current evaluation

Closed without merging. A reviewer found fundamental issues with mapping setuptools long_description to snap descriptions and proposed abandoning the PR as it is no longer useful.

Suggested action:

No scores available.

Issue body

* Use setuptools' description as snapcraft's summary * Use setuptools' long_description as snapcraft's description Fixes LP https://bugs.launchpad.net/snapcraft/+bug/1813364 See also https://forum.snapcraft.io/t/using-external-metadata/4642/10 - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? This fails for me, I get: ``` $ ./runtests.sh tests/unit tests.unit (unittest.loader._FailedTest) ... ERROR ====================================================================== ERROR: tests.unit (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.unit Traceback (most recent call last): File "/usr/lib/python3.6/unittest/loader.py", line 462, in _find_test_path package = self._get_module_from_name(name) File "/usr/lib/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/home/ijohnson/git/snapcraft/tests/unit/__init__.py", line 24, in <module> import fixtures ModuleNotFoundError: No module named 'fixtures' ---------------------------------------------------------------------- Ran 1 test in 0.000s FAILED (errors=1) ``` ----- Also let me know if I need to change/modify any tests for this, this is my first PR to snapcraft :smiley: so I'm not sure what all should be changed for this

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without merging. A reviewer found fundamental issues with mapping setuptools long_description to snap descriptions and proposed abandoning the PR as it is no longer useful.
qwen3.6-35b-a3b-mtp-q6 Mapped setuptools metadata to snapcraft fields. After test updates, a maintainer identified issues with using long_description as the description and closed the pull request as it is no longer useful.
qwen3.6-35b-a3b-mtp-q6 Closed without merging. A maintainer identified issues with using setuptools long_description as the snap description and proposed closing due to limited usefulness and unresolved implementation concerns.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.