← Back to issue list

ci: improve travis integration conditionals

View original Github issue

Metadata

Project
snapcraft
Number
#2523
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged updates to Travis CI configuration that correct spread test conditionals, preventing failures from missing Google Keys. Removes an unused cron trigger and standardizes .travis.yml indentation. Approved by one reviewer.

Suggested action:

No scores available.

Issue body

The integration conditionals were wrong for the spread tests as they require Google Keys which not many people have setup before hand leading to many failed runs when pushing to branches not owned by snapcore/snapcraft. Also remove the unnecessary cron conditional, as it is no longer used. Additionally, indent the integration scripts so they match all other declarations in .travis.yml Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged updates to Travis CI configuration that correct spread test conditionals, preventing failures from missing Google Keys. Removes an unused cron trigger and standardizes .travis.yml indentation. Approved by one reviewer.
qwen3.6-35b-a3b-mtp-q6 Merged. Corrected Travis CI integration conditionals for spread tests to prevent failures from missing Google Keys, removed an unused cron trigger, and standardized script indentation in .travis.yml.
qwen3.6-35b-a3b-mtp-q6 Merged. Fixed Travis CI spread test conditionals to prevent failures from missing Google Keys, removed an unused cron trigger, and improved .travis.yml indentation. Codecov reported missing base coverage, but changes were merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1560 ci: use travis conditionals snapcraft merged Merged pull request updating CI configuration to use Travis conditionals. The change modified one file (+20/-10 lines) and received approval from one reviewer before being integrated.
85%
#2217 Travis test snapcraft merged Merged after approval. Updated Travis CI configuration across 26 files, reducing 483 lines. A Codecov base commit warning appeared but did not prevent the merge.
72%
#2383 ci: use more travis primitives for osx tests snapcraft merged Merged PR #2383 updates Travis CI configuration to use native primitives for macOS testing and removes an unused Docker service. Approved, passed CI checks, and integrated into master.
71%