← Back to issue list

ci: improve travis integration conditionals

View original Github issue

Metadata

Project
snapcraft
Number
#2523
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 4900f7323: .travis.yml spread/integration test conditionals fixed, unused cron trigger removed, integration script indentation normalized.

Resolution: closed resolved

Reason: PR snapcraft#2523 was approved and merged into master as commit 4900f7323 ("ci: improve travis integration conditionals"), fixing the Travis conditionals that gated spread/integration tests requiring Google keys, dropping the unused cron conditional, and re-indenting the integration script entries.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The integration conditionals were wrong for the spread tests as they require Google Keys which not many people have setup before hand leading to many failed runs when pushing to branches not owned by snapcore/snapcraft. Also remove the unnecessary cron conditional, as it is no longer used. Additionally, indent the integration scripts so they match all other declarations in .travis.yml Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 4900f7323: .travis.yml spread/integration test conditionals fixed, unused cron trigger removed, integration script indentation normalized.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#2523 (4900f7323) corrected Travis spread-test conditions, removed an unused cron trigger, and normalized integration-script indentation.
qwen/qwen3.6-35b-a3b — — Merged updates to Travis CI configuration that correct spread test conditionals, preventing failures from missing Google Keys. Removes an unused cron trigger and standardizes .travis.yml indentation. Approved by one reviewer.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Corrected Travis CI integration conditionals for spread tests to prevent failures from missing Google Keys, removed an unused cron trigger, and standardized script indentation in .travis.yml.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1560 ci: use travis conditionals snapcraft merged PR #1560 merged as commit caa20e0f5, refactoring .travis.yml to gate jobs with Travis conditionals (+20/-10).
81%
#1638 tests: reorganize unit and integration suites to make them easier to split for travis snapcraft merged Merged #1638 as commit 30f62685c, reorganizing unit and integration test suites for easier splitting across Travis CI jobs.
71%
#1252 ci: split plugin integration tests out. snapcraft merged Merged PR #1252 in commit 1387c0aa9, splitting plugin integration tests into separate Travis CI runs to stay within time limits.
71%