← Back to issue list

project: validate common-id against metadata filename

View original Github issue

Metadata

Project
snapcraft
Number
#2536
Type
pull request
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged in favor of #2542, which reworked the validation and was merged as 8d7f16595 to reject AppStream common IDs missing from metadata files.

Resolution: closed superseded

Reason: The author stated that #2536 would be reworked, and replacement PR #2542 was merged as commit 8d7f16595 with the intended common-ID validation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Appstream common IDs is also used in the metadata file names. To prevent typos, add a consistency check and fail if any common ID is not used in metadata files. LP: #1814902 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #2542, which reworked the validation and was merged as 8d7f16595 to reject AppStream common IDs missing from metadata files.
stealth/space-bunny-alpha — closed superseded Closed unmerged after rework; replacement #2542 was merged as commit 8d7f16595, validating AppStream common IDs against metadata filenames.
qwen/qwen3.6-35b-a3b — — Closed without merging. The author abandoned the common ID validation against metadata filenames to implement a different approach.
qwen3.6-35b-a3b-mtp-q6 — — Proposed validation of Appstream common IDs against metadata filenames was closed without merging. The author indicated plans to rework the implementation using a different approach, effectively abandoning the current changes.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#2542 (confidence 100%)

    Merged replacement implementation, recorded as commit 8d7f16595.

Related issues

Issue Project State Summary Similarity
#2542 meta: Validate common ID against appstream metadata snapcraft merged Merged PR #2542 added validation that fails when an app's common-id is absent from AppStream metadata, preventing common-ID typos.
82%