rust plugin: fix usage of rust-channel
Metadata
Current evaluation
Merged PR #2538 fixed Rust plugin toolchain setup by using rustup instead of the obsolete rustup.sh --channel argument; resolving commit: 4eb089546.
Resolution: closed resolved
Reason: PR #2538 was merged into master as commit 4eb089546. It configures rust-channel through rustup, fixes Launchpad bug #1825062, and removes the unused toolchain variable.
Evaluated by: mr-cal-bot
No scores available.
Issue body
rustup.sh no longer accepts a --channel argument. Fix by setting up the
toolchain using rustup.
For consistency, do not install the default toolchain on toolchain setup
and instead use the former mechanism for all code paths.
Lastly, remove an unsued variable in RustPlugin._get_toolchain
LP: #1825062
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2538 fixed Rust plugin toolchain setup by using rustup instead of the obsolete rustup.sh --channel argument; resolving commit: 4eb089546. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2538 (commit 4eb089546) replaced rustup.sh's obsolete --channel argument with rustup toolchain setup, unified toolchain installation, and removed an unused variable. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged PR #2538 fixes the Rust plugin by replacing the deprecated rustup.sh channel argument with rustup toolchain setup. Approved, passed CI, and merged to master. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the rust plugin to configure toolchains via rustup instead of the deprecated --channel flag and removed an unused variable. Resolves LP: #1825062 with full diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2434 rust plugin: refactor to use the latest rustup | snapcraft | merged | Merged PR #2434 in commit 3e821ca8d, updating the Rust plugin for current rustup, sharing toolchain storage, and adopting .cargo/config. | |
| #2431 rust plugin: update to use latest rustup command options | snapcraft | merged | Merged PR #2431 updated the Rust plugin to use current rustup options instead of deprecated commands; landed as commit 3e821ca8d. | |
| #560 rust_plugin: multiple fixes | craft-parts | merged | Merged rust_plugin fixes: removed typing checks around the rust_channel override and added detection/removal of installed compiler plugins via the .data.rel.ro symbol. Squash-merged as fbefe6b8; fixes #559. | |
| #2613 rust plugin: use rust-toolchain by default if present | snapcraft | merged | Merged PR #2613 in commit 374f042a5, making the Rust plugin use a source rust-toolchain file by default and fall back to stable only when no explicit setting is supplied. | |
| #1467 rust plugin: new rustup | snapcraft | closed | Updated the Rust plugin’s outdated rustup download link via merged PR #2438 (commit ea6caa72b), resolving LP bug #1662960. | |
| #1774 fix(plugins/rust): don't require rustup when rust-deps is defined | craft-parts | merged | Fixed a regression in the Rust plugin where rust-deps provisioning failed without rust-channel: none by removing the unnecessary rustup requirement. Merged in #1774. | |
| #2438 rust plugin: new link for rustup | snapcraft | merged | Merged PR #2438 (commit ea6caa72b) updating the Rust plugin's rustup download link, fixing LP bug #1662960 where the plugin used an outdated rustup URL. | |
| #530 plugins/rust_plugin: rewrite the plugin to improve UX | craft-parts | merged | Merged via commit 939e6d77, rewriting the Rust plugin to install Rustup by default and adding LTO, toolchain-channel, and default-feature controls. | |
| #1681 docs: update reference for the rust plugin | craft-parts | merged | Merged PR #1681 (commit e66bea2f) updated Rust plugin docs for current behavior, resolving outdated dependency guidance, rust-channel defaults, and provisioning details in #912 and #593. | |
| #1825062 Found argument '--channel' which wasn't expected, or isn't valid in this context | snapcraft (launchpad) | closed | Fixed rust-channel handling by replacing obsolete rustup.sh --channel usage; PR canonical/snapcraft#2538 merged as 4eb089546. |