rust plugin: fix usage of rust-channel
Metadata
Current evaluation
Merged PR #2538 fixes the Rust plugin by replacing the deprecated rustup.sh channel argument with rustup toolchain setup. Approved, passed CI, and merged to master.
Suggested action: —
No scores available.
Issue body
rustup.sh no longer accepts a --channel argument. Fix by setting up the
toolchain using rustup.
For consistency, do not install the default toolchain on toolchain setup
and instead use the former mechanism for all code paths.
Lastly, remove an unsued variable in RustPlugin._get_toolchain
LP: #1825062
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged PR #2538 fixes the Rust plugin by replacing the deprecated rustup.sh channel argument with rustup toolchain setup. Approved, passed CI, and merged to master. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the rust plugin to configure toolchains via rustup instead of the deprecated --channel flag and removed an unused variable. Resolves LP: #1825062 with full diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the Rust plugin to replace the deprecated rustup.sh channel argument with proper rustup toolchain setup. Standardized initialization across code paths and removed an unused variable. Passed unit tests with 100% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2434 rust plugin: refactor to use the latest rustup | snapcraft | merged | Merged Rust plugin refactor for latest rustup. Removed deprecated flags, added command qualifiers, established shared rustup/cargo directory, and standardized config. Approved and passed CI. | |
| #2438 rust plugin: new link for rustup | snapcraft | merged | Merged into master after approval and passing CI. Updated the rust plugin to use a new rustup link, addressing LP #1662960. Modified 3 files with 11 additions and 6 deletions. | |
| #560 rust_plugin: multiple fixes | craft-parts | merged | Merged Rust plugin fixes resolving issue #559. Changes remove unnecessary rust_channel override typing checks and improve compiler plugin identification and removal. Approved by reviewers and merged despite an unrelated CI pylint failure. | |
| #2613 rust plugin: use rust-toolchain by default if present | snapcraft | merged | Merged. The Rust plugin now defaults to a rust-toolchain file if present, falling back to the stable channel. Approved by a reviewer and passed CI checks before merge. | |
| #2431 rust plugin: update to use latest rustup command options | snapcraft | merged | Merged update to the Rust plugin replacing deprecated rustup command options with current equivalents. Approved by a reviewer, passed CI, modified five files, and maintained 94.5% test coverage. | |
| #570 rust_plugin: multiple fixes (#560) | craft-parts | merged | Merged as #560. The rust_plugin was updated to remove compiler plugins from final Snap packages and eliminate a redundant channel override causing type-checking errors. Approved by one reviewer and passed CI checks. | |
| #1681 docs: update reference for the rust plugin | craft-parts | merged | Updates the Rust plugin reference doc to match current behavior (rust-channel default is None, rust-deps usage). Fixes craft-parts#912 and #593. Approved by 2 reviewers; CI mostly green with unrelated java/flaky failures. | |
| #530 plugins/rust_plugin: rewrite the plugin to improve UX | craft-parts | merged | Merged a Rust plugin rewrite improving UX with default Rustup, LTO, toolchain version, and feature toggles. Failing tests for Ubuntu 20.04 Chisel support were resolved via a separate PR and rebasing prior to merge. |