← Back to issue list

catkin spread tests: restrict tests to Ubuntu 16.04

View original Github issue

Metadata

Project
snapcraft
Number
#2573
Type
pull request
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #2573 (filter Catkin spread tests to Ubuntu 16.04, dropping EOL 14.04) was not merged; maintainer kyrofa closed it in favour of #2575, which was merged as commit 2c1b97bf4.

Resolution: closed superseded

Reason: kyrofa commented "I suggest #2575 over this one" (2019-05-28) and the PR was closed unmerged. #2575 (commit 2c1b97bf4) achieved the same effect by replacing the EOL Indigo series with Kinetic, making the Ubuntu 14.04/16.04 filter changes unnecessary; it also addressed LP: #1830769.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Ubuntu 14.04 LTS is in extended security maintenance mode. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #2573 (filter Catkin spread tests to Ubuntu 16.04, dropping EOL 14.04) was not merged; maintainer kyrofa closed it in favour of #2575, which was merged as commit 2c1b97bf4.
stealth/space-bunny-alpha — closed superseded Not merged; superseded by #2575, which replaced the Ubuntu 16.04-only filter by switching Catkin spread tests from Indigo to Kinetic.
qwen/qwen3.6-35b-a3b — — Restricting catkin spread tests to Ubuntu 16.04 was closed and superseded by PR #2575, as recommended by the reviewer.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by pull request #2575. The changes to restrict catkin spread tests to Ubuntu 16.04 were abandoned in favor of an alternative approach.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#2575 (confidence 98%)

    Maintainer explicitly recommended #2575 instead; that PR was merged as commit 2c1b97bf4.

  • Related To: canonical/snapcraft#2584 (confidence 55%)

    Follow-up 'catkin spread tests: finer system filter for legacy-pull' (commit 811c0fd37) in the same series.

Related issues

Issue Project State Summary Similarity
#2575 catkin spread tests: use kinetic instead of indigo snapcraft merged Merged PR #2575 in commit 2c1b97bf4, switching Catkin spread tests from EOL Indigo to Kinetic and removing obsolete Ubuntu 14.04 filters, resolving LP #1830769.
77%
#2221 spread: stop running catkin tests on 18.10 snapcraft merged Merged #2221 (commit abc47cbf4), disabling catkin spread tests on Ubuntu 18.10 and switching Google Cloud zones to us-east1-b.
75%
#2584 catkin spread tests: finer system filter for legacy-pull snapcraft merged PR #2584 merged as 811c0fd37, restoring the architecture filter for catkin legacy-pull spread tests to prevent unintended ppc64el runs after #2575.
75%
#2572 [legacy] catkin spread tests: stop testing indigo snapcraft merged Merged legacy branch PR (2019): swapped EOL Indigo for Kinetic in Catkin spread tests and dropped 14.04 tests, resolving LP: #1830769. Mainline equivalent merged as snapcore/snapcraft#2575 (commit 2c1b97bf4).
72%
#1830769 Catkin plugin: tests failing due to indigo EOL snapcraft (launchpad) closed Catkin spread tests were moved from EOL ROS Indigo to Kinetic by merged PR canonical/snapcraft#2575 (commit 2c1b97bf4); PR #2572 handled the release branch.
71%
#1783829 Move Catkin Tools plugin tests to spread snapcraft (launchpad) closed Catkin Tools integration coverage was migrated from Python to Spread by merged canonical/snapcraft#2206 (317d4a03a); LP #1783829 was later closed as stale housekeeping.
70%
#2989 tests: only run catkin based snap on 16.04 snapcraft merged Merged in #2989 (commit 7e1b62231), restricting the catkin-based snap test to Ubuntu 16.04 to prevent timeouts on 18.04.
70%
#1783828 Move Catkin plugin tests to spread snapcraft (launchpad) closed Catkin plugin integration tests were migrated from Python to a Spread suite by merged PR #2206, commit 317d4a03a.
70%
#2610 catkin spread tests: dump apt-config on failures for legacy snapcraft merged Merged PR #2610 in commit 27424951b, adding apt-config dumps on legacy catkin spread-test failures to diagnose intermittent GCE failures.
70%