[legacy] catkin plugin: remove default rosdistro
Metadata
Current evaluation
Merged into legacy via snapcore/snapcraft#2576, removing the Catkin plugin's EOL Indigo default and requiring users to specify a ROS distribution.
Resolution: closed resolved
Reason: PR #2576 was merged into the legacy branch and fixes LP #1830784 by eliminating the implicit Indigo selection so rosdistro must be explicitly configured.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
The Catkin plugin currently defaults to using Indigo, a now-EOL ROS distro. Anyone relying on that default is now unable to build a snap. They will probably need to start using another one to get unblocked. Rather than simply set the default to something else and potentially run into this issue again, this PR resolves [LP: #1830784](https://bugs.launchpad.net/snapcraft/+bug/1830784) by getting rid of the default altogether and making users specify which one they want, thus keeping behavior predictable in the future.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into legacy via snapcore/snapcraft#2576, removing the Catkin plugin's EOL Indigo default and requiring users to specify a ROS distribution. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2576 (2019-05-28, into legacy) removed the legacy Catkin plugin's default Indigo ROS distro, now requiring users to set one. Fixes LP: #1830784. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2576 removed the legacy Catkin plugin's default Indigo ROS distribution, requiring users to specify a distro and resolving LP: #1830784. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Removes the EOL Indigo default from the catkin plugin to prevent build failures. Users must now explicitly specify a ROS distribution, resolving LP: #1830784 and ensuring predictable future behavior. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into legacy. Removes the EOL Indigo default from the Catkin plugin, requiring explicit ROS distro specification to prevent future build failures. Resolves Launchpad #1830784. Diff coverage is 100%. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#2575
(confidence 95%)
Companion change updated Catkin spread tests from Indigo to Kinetic.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1830784 Catkin plugin: stop using EOL indigo as default rosdistro | snapcraft (launchpad) | closed | Catkin’s legacy ROS distribution default was removed in snapcore/snapcraft#2576, requiring users to specify a distro instead of defaulting to EOL Indigo. | |
| #1500922 ros-catkin-plugin: ros distro issue | snapcraft (launchpad) | closed | Moved to canonical/snapcraft#43; the ROS Jade path mismatch was traced to example configuration and resolved by changing it to Indigo. | |
| #1548404 Catkin plugin: Can't handle rosdep resolving to multiple packages | snapcraft (launchpad) | closed | Fixed by ubuntu-core/snapcraft PR #331 (commit 1c1119ce3, 'Catkin plugin: Handle rosdep empty and multiple dependencies'), merged as e3a2b9d03; maintainer ~kyrofa linked the PR when closing the Launchpad bug. | |
| #850 catkin plugin: add `rosdistro` to help documentation. | snapcraft | merged | Merged PR #850 (commit c3817b42d) added the `rosdistro` parameter to `snapcraft help catkin` output, closing Launchpad bug #1629955. Docs-only change, 3 lines added. | |
| #163 Catkin plugin: use rosdep for dependency resolution | snapcraft | merged | Merged in PR #163 (commit 87b2e24f6), replacing manual Catkin package.xml dependency parsing with rosdep; PR #183 backported the change to Snapcraft 1.x. | |
| #1629955 rosdistro is not documented in the catkin plugin help | snapcraft (launchpad) | closed | The catkin plugin's help text omitted the `rosdistro` keyword. Fixed by merged PR snapcore/snapcraft#850 (commit c3817b42d), a docs-only change adding `rosdistro` to the plugin help, closing the Launchpad bug. | |
| #331 Catkin plugin: Handle rosdep empty and multiple dependencies. | snapcraft | merged | PR #331 merged into snapcraft master as commit 1c1119ce3 (merge e3a2b9d03). It refactored the Catkin plugin's rosdep dependency resolution to handle empty output and multiple packages per line, fixing LP bugs #1548406 and #1548404. | |
| #1548406 Catkin plugin: Can't handle rosdep resolving to nothing | snapcraft (launchpad) | closed | Fixed by canonical/snapcraft#331, merged as commit 1c1119ce3; Catkin now treats empty rosdep output as no dependencies instead of an error. |