← Back to issue list

pluginhandler, repo: find stage-packages from DT_NEEDED on host

View original Github issue

Metadata

Project
snapcraft
Number
#2632
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged. Adds DT_NEEDED analysis to primed files, automatically suggesting missing stage-packages. Addressed reviewer feedback on caching optimization, passed all CI checks, and maintained 98.14% test coverage.

Suggested action:

No scores available.

Issue body

After priming, DT_NEEDED is checked for in all the files that were primed and a list of missing files is listed, `stage-packages` are now listed for the cases where these can be satisfied by adding them. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Adds DT_NEEDED analysis to primed files, automatically suggesting missing stage-packages. Addressed reviewer feedback on caching optimization, passed all CI checks, and maintained 98.14% test coverage.
qwen3.6-35b-a3b-mtp-q6 Merged. Automatically resolves missing stage-packages by analyzing DT_NEEDED dependencies on the host. The resolver caches dpkg queries via lru_cache to optimize performance and suggests required packages.
qwen3.6-35b-a3b-mtp-q6 Merged implementation resolving missing ELF dependencies by checking DT_NEEDED in primed files and suggesting stage-packages. Optimized with lru_cache to cache dpkg -S queries. Merged with 98% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1059 pluginhandler: support more complex stage-packages. snapcraft merged Merged. Adds a complex grammar for stage-packages using on and try/else clauses to filter packages by selectors like target architecture, resolving LP #1637282. Approved by reviewer and passed CI.
73%