← Back to issue list

meta: transparently support command-chain

View original Github issue

Metadata

Project
snapcraft
Number
#2652
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged. Removes checks blocking command-chain usage, automatically switching to full-mode when present in app entries. Approved by maintainer, passed CI, and updated 6 files.

Suggested action:

No scores available.

Issue body

Remove checks that invalidated the use of command-chain without any other adapter than full. Instead, transparently move to full-mode if a command-chain is present in an apps entry. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Removes checks blocking command-chain usage, automatically switching to full-mode when present in app entries. Approved by maintainer, passed CI, and updated 6 files.
qwen3.6-35b-a3b-mtp-q6 Merged changes removing validation checks that blocked command-chain usage. The update now transparently switches to full-mode when a command-chain is present in an app entry, with coverage verified prior to integration.
qwen3.6-35b-a3b-mtp-q6 Merged. Removes validation checks blocking command-chain without the full adapter, automatically switching to full-mode when command-chain is present in an app entry. Code coverage diff reported at 66.66%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2731 meta: take no command-chain being prepended into account snapcraft merged Merged a fix preventing empty command-chains in the apps entry during classic confinement, where the core omits prepending one. Approved by reviewer, passed CI, and modified two files.
80%
#2850 hooks: enable command-chain snapcraft merged Merged changes enabling command-chain support in hooks regardless of base. The update passes through user-defined command-chain configurations from snapcraft.yaml without actively enabling it. Approved by one reviewer and passed CI checks.
71%