← Back to issue list

tests: move meta testing to its own package

View original Github issue

Metadata

Project
snapcraft
Number
#2666
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2666 (commit 13316e8d7, 2019-08-15) by maintainer sergiusens: relocated meta tests into a dedicated package as groundwork for adding more meta test modules. Test-only refactor, approved with no unresolved comments.

Resolution: closed resolved

Reason: The PR itself was merged into master as commit 13316e8d7 with the commit message 'tests: move meta testing to its own package'. It was a pure test-directory reorganization (2 files changed) approved by one reviewer, with no follow-up fixes requested.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- Very simple PR to prepare the terrain for more test modules for meta

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2666 (commit 13316e8d7, 2019-08-15) by maintainer sergiusens: relocated meta tests into a dedicated package as groundwork for adding more meta test modules. Test-only refactor, approved with no unresolved comments.
stealth/space-bunny-alpha — closed resolved Merged PR #2666 (commit 13316e8d7) by maintainer sergiusens relocated snapcraft's meta tests into a dedicated tests/unit/meta package, clearing the way for additional meta test modules.
stealth/space-bunny-alpha — closed resolved Merged PR #2666 in commit 13316e8d7, moving meta tests into a dedicated package to prepare for additional meta test modules.
qwen/qwen3.6-35b-a3b — — Merged a refactoring change that relocates meta testing code into a dedicated package to streamline future test module development. Approved by maintainers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. The change reorganizes meta testing into a dedicated package to streamline future test module development. Despite a Codecov report indicating missing base coverage, the refactoring was approved and integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1391 tests: reduce the amount of test code in test_meta snapcraft merged Merged PR #1391 (commit 4f891d4b1) shrank tests/unit/test_meta.py by 31 net lines (+65/-96), replacing repeated file setup with the new _create_file helper and testtools assertions. Test-only refactor, approved by one reviewer.
74%