← Back to issue list

docker: parametrize risk and OS for image builds (core18 etc)

View original Github issue

Metadata

Project
snapcraft
Number
#2673
Type
pull request
State
merged
Author
abitrolly
Labels
—
Created
Updated
Closed

Current evaluation

Merged as b982555e1, parameterizing Docker image builds by Ubuntu core (such as core18) and risk level for command-line selection without Dockerfile edits.

Resolution: closed resolved

Reason: PR #2673 was merged as commit b982555e1, adding configurable OS and risk build arguments. Follow-up PR #3499 later documented selecting the Ubuntu version.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR allows to change Ubuntu version and risk level of docker image from command line without editing Dockerfiles as advised at https://forum.snapcraft.io/t/creating-docker-images-for-snapcraft/11739 - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as b982555e1, parameterizing Docker image builds by Ubuntu core (such as core18) and risk level for command-line selection without Dockerfile edits.
stealth/space-bunny-alpha — closed resolved Merged as commit b982555e1 ("docker: parametrize risk and OS for image builds (core18 etc) (#2673)"), replacing multiple per-risk Dockerfiles with build-arg parameterized builds (e.g. core18).
stealth/space-bunny-alpha — closed resolved Merged in snapcraft PR #2673 (b982555e1), adding command-line build parameters for Ubuntu core and risk level so Dockerfiles no longer need editing.
qwen/qwen3.6-35b-a3b — — Merged after CLA verification and review. The update enables command-line parameterization of Ubuntu version and risk level for Docker builds, removing manual Dockerfile edits. Documentation updates for the new parameters were noted for follow-up.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Enables command-line parametrization of Ubuntu risk level and OS version for Docker image builds. CLA verification delays were resolved by re-signing the agreement. README.md was updated with build instructions, while forum documentation updates remain pending.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3499 (confidence 99%)

    Merged documentation follow-up 226da60e8 explained how to select the Ubuntu version.

  • Likely Fixed By: snapcraft#3500 (confidence 90%)

    Commit 1c411e87a corrected Docker ARG scope so the new parameters worked across every Dockerfile section.

Related issues

Issue Project State Summary Similarity
#3384 Add core20 to various /Dockerfile/s snapcraft closed Closed unmerged in favor of #2673; the broader Docker OS/risk parameterization (commit b982555e1) replaced the proposed core20-specific changes, with CI and separate image-tag publication still required.
74%