erorrs: preserve quotes when printing SnapcraftPluginCommandError
Metadata
Current evaluation
Merged PR #2677 fixed failed-command output by applying shlex.quote() to each argument; landed as commit 098e7d5d5.
Resolution: closed resolved
Reason: PR #2677 was approved and merged into master. Commit 098e7d5d5 preserves effective shell quoting when SnapcraftPluginCommandError prints the failed command.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The exception will not show any effective quotes in the command.
This uses shlex.quote() to print a more accurate description of
the command that failed.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2677 fixed failed-command output by applying shlex.quote() to each argument; landed as commit 098e7d5d5. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2677 as commit 098e7d5d5, using shlex.quote() when formatting SnapcraftPluginCommandError so failed commands retain effective shell quotes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2677 as commit 098e7d5d5, using shlex.quote() when rendering SnapcraftPluginCommandError to preserve shell-effective quotes in failed-command output. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2677 applies shlex.quote() when formatting SnapcraftPluginCommandError, restoring effective shell quotes in failed-command output (commit 098e7d5d5). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Applies shlex.quote() to SnapcraftPluginCommandError output, preserving command quotes for accurate error reporting. Approved by two reviewers, passed CI, and increased test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to master. Applies shlex.quote() to SnapcraftPluginCommandError output, preserving command quotes for accurate error reporting. Approved after rebasing and passing unit tests. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#2686
(confidence 65%)
Referenced during review in discussion of command quoting, but it was not the resolving change.
Related issues
No related issues found above the similarity threshold.