← Back to issue list

colcon plugin: add ability to ignore packages in workspace

View original Github issue

Metadata

Project
snapcraft
Number
#2679
Type
pull request
State
closed
Author
danielwangksu
Labels
—
Created
Updated
Closed

Current evaluation

PR adding packages-ignore to the colcon plugin was closed in favour of canonical/snapcraft#2687, which merged as commit bdc2150bb and shipped the colcon-packages-ignore option.

Resolution: closed superseded

Reason: Maintainer kyrofa closed the PR on 2019-08-26 with 'Closing in favor of #2687' after it went stale with conflicts. The successor PR #2687 merged as commit bdc2150bb, and colcon-packages-ignore is present today in snapcraft/parts/plugins/colcon_plugin.py plus docs and spread/unit tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- plugin colcon: add ability to ignore packages in workspace to colcon plugin `colcon build` supports `--packages-ignore` to explicitly specify packages to skip for this build. This PR add the `packages-ignore`ability to snapcraft colcon plugin

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR adding packages-ignore to the colcon plugin was closed in favour of canonical/snapcraft#2687, which merged as commit bdc2150bb and shipped the colcon-packages-ignore option.
stealth/space-bunny-alpha — closed superseded Closed as superseded by canonical/snapcraft#2687, which merged as bdc2150bb and added package-ignore support to the colcon plugin.
stealth/space-bunny-alpha — closed superseded Closed in favor of #2687, which was merged as bdc2150bb to add packages-ignore support to the colcon plugin.
stealth/space-bunny-alpha — closed superseded Closed as superseded by merged PR #2687, which added packages-ignore support to the colcon plugin in commit bdc2150bb.
qwen/qwen3.6-35b-a3b — — The pull request was closed and superseded by PR 2687. The proposed colcon plugin feature was not merged due to an alternative implementation.
qwen3.6-35b-a3b-mtp-q6 — — Adding packages-ignore support to the colcon plugin was closed and superseded by PR #2687 after a maintainer requested conflict resolution.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#2687 (confidence 98%)

    Explicit maintainer comment 'Closing in favor of #2687'; that PR merged as bdc2150bb with the same feature.

  • Related To: canonical/snapcraft@bdc2150bb (confidence 85%)

    Resolving commit adding colcon-packages-ignore to the colcon plugin; the option is still documented in docs/reference/plugins/colcon_plugin.rst and covered by tests.

Related issues

Issue Project State Summary Similarity
#2687 colcon plugin: add ability to ignore packages snapcraft merged Merged PR #2687 as commit bdc2150bb, adding support to ignore selected packages in colcon workspaces.
90%