spread tests: minor performance improvements
Metadata
Current evaluation
Merged minor spread test performance improvements. Changes include conditional multipass installation, --purge on snap removals, and increasing GCE workers for 16.04 to 12. Approved, passed CI, and maintained coverage.
Suggested action: —
No scores available.
Issue body
- Only install multipass for the tests that need it (they are manual).
- --purge on snap removals to avoid snapshotting.
- More workers for 16.04 on GCE (8->12).
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged minor spread test performance improvements. Changes include conditional multipass installation, --purge on snap removals, and increasing GCE workers for 16.04 to 12. Approved, passed CI, and maintained coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Applied minor performance improvements to spread tests by conditionally installing multipass, using --purge on snap removals, and increasing GCE workers for 16.04. Code coverage unchanged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged minor spread test performance improvements. Optimized tests by conditionally installing multipass, adding --purge to snap removals, and increasing GCE workers for 16.04 from 8 to 12. Codecov confirms unchanged coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration. | |
| #2367 tests: add spread test exercising multipass build VMs | snapcraft | merged | Merged. Implemented spread tests for multipass build VMs and migrated amd64 Xenial and Bionic tests to GCE with nested KVM, resolving LP: #1798682. Approved by one reviewer with passing CI checks across seven files. | |
| #3026 spread tests: add core20 and cleanup systems | snapcraft | merged | Merged. Added core20 support to spread tests, cleaned up system selection logic to exclusively install snaps, and introduced a dedicated environment for unit tests. A reported test failure was promptly fixed by the author before approval and merge. | |
| #2771 ci: always discard spread workers in snap-store-tests (main) | charmcraft | merged | Merged CI fix adding cleanup to discard spread workers in snap-store-tests. Prevents Google Cloud VM leaks on cancellation or crash, aligning with other jobs. Approved and merged despite minor CI failures. | |
| #3540 spread tests: remove 16.04 and core (CRAFT-210) | snapcraft | merged | Merged cleanup removing legacy 16.04 and core references from spread tests. Approved with passing CI. Author noted necessary legacy tests will be reintroduced in future iterations. | |
| #3432 spread tests: remove legacy plugin tests | snapcraft | merged | Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged an improved snap inspector test that emulates system setup by stopping snapd, clearing device files, setting a global proxy, and restarting snapd to uncover network requests. Approved by two reviewers, passed all CI checks, and merged. | |
| #2333 ci: don't run spread tests when unnecessary | charmcraft | closed | Merged to optimize CI execution by skipping unnecessary spread tests and cancelling obsolete snap builds, reducing redundant pipeline runs. | |
| #2979 tests: add multipass adhoc spread backend | snapcraft | merged | Merged addition of a multipass adhoc spread backend to streamline local container and snap testing. Approved by a reviewer, passed CI, and updated one file with 38 lines of test configuration. | |
| #1272 tests: initial setup for the snapcraft snap tests with spread | snapcraft | merged | Merged to master following single reviewer approval. Introduced initial spread test infrastructure for snapcraft across four files (+39 lines). Code coverage remained stable at 95.33%. |