← Back to issue list

Go plugin: Unset all Go-related environment variables.

View original Github issue

Metadata

Project
snapcraft
Number
#269
Type
pull request
State
closed
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #269 (kyrofa) would unset Go env vars in the Go plugin for LP #1537728; never merged. Author closed it on 2016-01-28 saying it "opens a can of worms" and that the real fix is cleanbuild, delivered soon after in merged PR #328 (commit 2f6116267).

Resolution: closed superseded

Reason: Maintainer kyrofa closed the unmerged PR himself, stating the real solution is the cleanbuild command. That approach landed in merged PR #328 (commit 2f6116267, branch feature/1480144/cleanbuild-lxd), providing isolated LXD builds instead of scrubbing Go env vars.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR fixes LP: [#1537728](https://bugs.launchpad.net/snapcraft/+bug/1537728) by making sure the Go plugin runs in a clean Go environment.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #269 (kyrofa) would unset Go env vars in the Go plugin for LP #1537728; never merged. Author closed it on 2016-01-28 saying it "opens a can of worms" and that the real fix is cleanbuild, delivered soon after in merged PR #328 (commit 2f6116267).
stealth/space-bunny-alpha — closed superseded Unmerged Go environment cleanup; maintainer closed PR #269 in favor of the forthcoming cleanbuild solution.
qwen/qwen3.6-35b-a3b — — Closed without merging. The maintainer noted the change introduces complications and decided the proper fix requires a future cleanbuild feature instead.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The maintainer deemed the approach problematic and deferred to the upcoming cleanbuild feature, which will properly isolate the Go environment.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#328 (confidence 92%)

    cleanbuild command merged in 2f6116267, the solution the closing comment pointed to

  • Related To: snapcraft#1610 (confidence 45%)

    Later cleanbuild integration test fix (e38921ab3), confirming cleanbuild became the supported path

Related issues

No related issues found above the similarity threshold.