← Back to issue list

rust plugin: support for s390x

View original Github issue

Metadata

Project
snapcraft
Number
#2693
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Added s390x architecture support to the Rust plugin and merged. Approved by reviewer, passed CI checks, and modified three files with minimal changes. Coverage increased slightly.

Suggested action:

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Added s390x architecture support to the Rust plugin and merged. Approved by reviewer, passed CI checks, and modified three files with minimal changes. Coverage increased slightly.
qwen3.6-35b-a3b-mtp-q6 Merged into master, adding s390x architecture support to the Rust plugin. Authored by maintainer sergiusens, the change passed code coverage checks and increased overall coverage by less than 0.01%.
qwen3.6-35b-a3b-mtp-q6 Merged into master, adding s390x architecture support to the Rust plugin. The change passed validation and increased coverage by less than 0.01%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1350 rust plugin: Add support for cross-compilation snapcraft merged Cross-compilation support added to the Rust plugin for snapcraft's --target-arch flag. Approved and merged despite unresolved comments and lack of ARM hardware testing.
72%
#3850 meta: add support for s390x snapcraft merged Merged after approval and CI checks. Adds s390x architecture support to snapcraft 7 to align with snapcraft_legacy, modifying two files with four lines of code.
71%
#2373 rust plugin: add support for bases snapcraft merged Merged update to the Rust plugin adding base support for core16 and core18. Resolves Launchpad bug #1798681. Approved, passed CI, and achieved 100% diff coverage with a net zero line change across 23 files.
71%
#570 rust_plugin: multiple fixes (#560) craft-parts merged Merged as #560. The rust_plugin was updated to remove compiler plugins from final Snap packages and eliminate a redundant channel override causing type-checking errors. Approved by one reviewer and passed CI checks.
71%
#2790 tests: skip spread tests for rust on s390x snapcraft merged Merged changes to skip spread tests for Rust on s390x, as the stable toolchain lacks required components like clippy and rustfmt. The update modifies five files to bypass these architecture-specific failures.
71%