cmake plugin: support disable-parallel option
Metadata
Current evaluation
Merged. Updated the cmake plugin to inherit parallel_build_count from BasePlugin, enabling the disable-parallel option. Approved by reviewers, passed CI checks, and includes unit tests.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Currently the cmake plugin utilizes the `parallel_build_count` attribute from `Project`. This PR switches it over to using the one from the `BasePlugin` to support the `disable-parallel` option. It also verifies that it works with a test.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updated the cmake plugin to inherit parallel_build_count from BasePlugin, enabling the disable-parallel option. Approved by reviewers, passed CI checks, and includes unit tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after a formatting fix. The cmake plugin now uses BasePlugin's parallel build count, enabling the disable-parallel option and includes corresponding tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Switches the cmake plugin to use BasePlugin.parallel_build_count instead of Project.parallel_build_count, enabling the disable-parallel option. Includes tests and addresses formatting feedback. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1234 cmake plugin: Support `disable-parallel` parameter | craft-parts | open | Feature request to add disable-parallel support to the cmake plugin, mirroring the autotools plugin. Triaged with 'Needs information' label, waiting for a real-world use case. 363 days old, no comments, feature not yet implemented. | |
| #2669 Plugin catkin: forward parallel build count | snapcraft | merged | Merged. The catkin plugin now forwards parallel-build-count and disable-parallel options to the build command. Approved by three reviewers, passed CI checks, and replaces PR #2665. | |
| #698 Add option disable-parallel for all plugins. | snapcraft | merged | Merged adding a generic disable-parallel option to the BasePlugin, allowing developers to disable parallel building across all plugins for projects that do not support it. Updated from per-part to base-level implementation and approved after testing. | |
| #1167 feat: add parallel parameter to autotools plugin | craft-parts | merged | Merged a feature adding a disable_parallel boolean option to the autotools plugin to suppress the -j make flag. Approved by three reviewers, passed all CI checks, and updated the changelog to resolve issue #1069. | |
| #1242 make plugin: Support `disable-parallel` parameter | craft-parts | open | Make plugin lacks disable-parallel support. Triaged as low-priority enhancement by maintainer, explicitly awaiting a real-world use case that never arrived in 363 days. Feature still unimplemented; sibling plugin issues (cmake, go, python, etc.) in same state. |