← Back to issue list

cli: prompt for login if required

View original Github issue

Metadata

Project
snapcraft
Number
#2736
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged CLI update that prompts for login when required instead of exiting with an error. Approved and passed CI checks.

Suggested action: —

No scores available.

Issue body

Promp to login if it is required instead of exiting with an error. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged CLI update that prompts for login when required instead of exiting with an error. Approved and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged CLI changes to prompt for login when required, replacing the previous error exit behavior. Approved and integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 — — Merged. The CLI now prompts for login when required instead of exiting with an error. Approved and merged by cjp256.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1780 cli: add export-login command snapcraft merged Merged the export-login CLI command and a --with flag for login to support CI systems. Review feedback updated packages to snaps and adjusted formatting. Approved and merged.
73%
#2742 cli: use click utilities for login prompts snapcraft merged Merged refactoring of CLI login prompts to use Click utilities. Approved by one reviewer, the change modified 20 files with a net reduction of 108 lines. Six unresolved review comments were present at merge.
72%
#1869 cli: exported login should only be readable by owner snapcraft merged Merged a fix restricting CLI login file permissions to owner-only read access. Replaced click.File with click.Path to manually enforce secure file creation. Approved by two reviewers and passed CI checks.
71%