tests: fix mypy error with test_errors.py
Metadata
Current evaluation
Merged a fix for a mypy error in test_errors.py where SnapcraftException.__init__ incorrectly returned a value. Approved, passed CI, and integrated with a single-line change.
Suggested action: —
No scores available.
Issue body
Triggered by merging the mypy coverage and SnapcraftException
bits. The SnapcraftException had a mypy issue in test_errors:
(__init__ must return None).
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for a mypy error in test_errors.py where SnapcraftException.__init__ incorrectly returned a value. Approved, passed CI, and integrated with a single-line change. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for a mypy error in test_errors.py where SnapcraftException.__init__ incorrectly returned a value instead of None. The change resolves type checking failures introduced by recent mypy coverage updates. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for a mypy error in test_errors.py where SnapcraftException.__init__ incorrectly returned a value. The update resolves type checking failures introduced by recent mypy coverage changes. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2752 errors: migrate handful of errors to SnapcraftException | snapcraft | merged | Merged. Migrates multiple error classes to SnapcraftException, adds a SnapcraftReportableException helper, simplifies error messages, and updates tests. Approved by a maintainer and passed CI checks. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change. |