← Back to issue list

make sure otp is included in login request only if it's not empty

View original Github issue

Metadata

Project
snapcraft
Number
#274
Type
pull request
State
merged
Author
ricardokirkner
Labels
—
Created
Updated
Closed

Current evaluation

PR #274 merged into snapcraft; commit cd3f46aa1 makes the store login request include the OTP field only when it is non-empty, fixing LP #1539208.

Resolution: closed resolved

Reason: The PR was merged by maintainer kyrofa after review, landing as commit cd3f46aa1 ("make sure otp is included in login request only if it's not empty LP: #1539208"), a 2-file, +11/-4 change to the store login request payload.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1539208

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #274 merged into snapcraft; commit cd3f46aa1 makes the store login request include the OTP field only when it is non-empty, fixing LP #1539208.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#274 to include OTP in login requests only when non-empty, resolving LP #1539208.
stealth/space-bunny-alpha — closed resolved Merged to omit empty OTP values from login requests, fixing the behavior tracked by LP #1539208.
stealth/space-bunny-alpha — closed resolved Merged PR #274 (commit cd3f46aa1), omitting empty OTP values from login requests and fixing LP #1539208.
qwen/qwen3.6-35b-a3b — — Merged to ensure OTP is only included in login requests when non-empty, resolving LP: #1539208. Approved by @kyrofa pending a minor commit message fix. The change modifies 2 files with 11 additions and 4 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged to conditionally include OTP in login requests only when non-empty. Approved by reviewer after minor commit message formatting adjustment. Resolves Launchpad bug #1539208.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1539208 (confidence 40%)

    Referenced as LP: #1539208 in the commit message and PR body (external Launchpad tracker, not in this repo).

Related issues

Issue Project State Summary Similarity
#1539208 snapcraft login fails if account does not require two factor authentication snapcraft (launchpad) closed Merged PR #274 fixed login by including OTP only when non-empty (commit cd3f46aa1; merge 1fc4fdffc).
76%