← Back to issue list

extensions: support using gjs from gnome runtime

View original Github issue

Metadata

Project
snapcraft
Number
#2741
Type
pull request
State
merged
Author
merlijn-sebrechts
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2741 in commit 55bfb2dfc, enabling snaps to use gjs bundled with GNOME runtime revision 87+ and eliminating redundant gjs packaging.

Resolution: closed resolved

Reason: PR #2741 was approved and merged into Snapcraft. Commit 55bfb2dfc added GNOME extension support for using the runtime-provided gjs.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR enables snaps to use the gjs bundled in the gnome runtime snap ([MR](https://gitlab.gnome.org/Community/Ubuntu/gnome-3-28-1804/merge_requests/1) accepted, available in revision 87 and up). I tested this with the foliate snap: https://github.com/snapcrafters/foliate/tree/gjs-via-gnome-extension This removes a lot of boilerplate and reduces the `foliate` snap size from `92M` to `324K`! *Note: `./runtests.sh static` gives the following error at the end, but this also happens on master.* ``` tests/unit/project_loader/grammar/test_compound_statement.py:223: error: Module has no attribute "errors" tests/unit/project_loader/grammar/test_compound_statement.py:235: error: Module has no attribute "errors" ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2741 in commit 55bfb2dfc, enabling snaps to use gjs bundled with GNOME runtime revision 87+ and eliminating redundant gjs packaging.
stealth/space-bunny-alpha — closed resolved Merged PR #2741, allowing snaps to use the gjs bundled in GNOME runtime extensions; landed in commit 55bfb2dfc.
qwen/qwen3.6-35b-a3b — — Merged changes enabling snaps to use gjs from the GNOME runtime extension. Approved by two reviewers after CI tests passed. Reduces boilerplate and significantly decreases snap size.
qwen3.6-35b-a3b-mtp-q6 — — Merged support for using gjs from the GNOME runtime snap in extensions, reducing boilerplate and snap sizes. Tests were restarted and approved by maintainers before merging.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3770 extensions: fix gnome run environment snapcraft merged Merged PR #3770, fixing the gnome-42 extension so generated snaps set LD_LIBRARY_PATH correctly in the runtime environment.
72%