← Back to issue list

meta: warn about command mangling

View original Github issue

Metadata

Project
snapcraft
Number
#2743
Type
pull request
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Closed in favor of #2748, merged as commit ae0c47bec to warn about required command wrappers and rewrites for snapd compatibility.

Resolution: closed superseded

Reason: Maintainer Sergio Schvezov explicitly closed #2743 in favor of #2748 on 2019-10-10. PR #2748 was subsequently merged as commit ae0c47bec.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Warn when a wrapper is needed due to the command used or when the command has changed to something more compatible with snapd's accepted format. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed in favor of #2748, merged as commit ae0c47bec to warn about required command wrappers and rewrites for snapd compatibility.
stealth/space-bunny-alpha — closed superseded Command-mangling warnings were moved to merged PR #2748; this attempt was closed on 2019-10-10 after review requested changes.
qwen/qwen3.6-35b-a3b — — Warnings for command mangling were closed by the maintainer in favor of PR #2748. Reviewers requested changes regarding dependency injection, but the author superseded the work with an alternative implementation.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded by PR #2748. The command mangling warnings were consolidated into the follow-up pull request following discussions on logging patterns and dependency injection for CLI output.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#2748 (confidence 100%)

    The author closed this PR in favor of #2748, which delivered the same command-mangling warning changes.

Related issues

Issue Project State Summary Similarity
#2748 meta: warn about command mangling snapcraft merged Command-mangling warnings were merged in #2748 for wrapper-requiring commands and commands rewritten to snapd-compatible formats.
88%
#3396 snap: address snapcraft warnings for app command snapcraft merged Merged PR #3396 as commit 524dd9811, applying a one-line fix to address Snapcraft warnings for the app command.
71%