Drop build_base check from make plugin. It is universal.
Metadata
Current evaluation
Closed unmerged and superseded by #2761, which delivered the full Core20-base solution and removed the make plugin's restrictive build_base check; the work later merged via #3579.
Resolution: closed superseded
Reason: Maintainer Sergio said the full solution was in canonical/snapcraft#2761, and this PR was closed as superseded rather than merged. The Core20-base work was ultimately merged through canonical/snapcraft#3579.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1842328
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
This is on a critical path blocking daily builds of Ubuntu Core images based on the published core20 snap. All other images for all other products are already produced daily for Focal Fossa release to become 20.04 LTS.
Please merge this, or equivalent functionality to edge channel as soon as possible. Alternatively please merge this into an a different branch "i.e. 20" and build snapcraft out of it into the snapstore published edge/20 branch such that all kernel / gadget / models can use it to start building core20 image due to be released in April 2020.
https://bugs.launchpad.net/snapcraft/+bug/1842328
Explaining the change. Unlike other plugins, make plugin is universal and has no dependencies or different codepaths which require adjustment between different build_bases. And even the package name "make" is universal across multiple distributions out there.
Until there is a code requirement, to adjust make plugin behaviour based on build_base, make plugin should not hardcode specific build_bases.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and superseded by #2761, which delivered the full Core20-base solution and removed the make plugin's restrictive build_base check; the work later merged via #3579. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and superseded by PR #2761, which delivered full Core20 base support, including removal of the make plugin’s restrictive build_base check. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed and superseded by PR #2761, which contains the full solution for removing the build_base check. The original changes were not merged independently as the fix required broader updates. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by PR #2761. The change was closed without direct merge after maintainers identified a more comprehensive fix in another pull request to resolve the Ubuntu Core 20 blocking issue. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#2761
(confidence 100%)
The maintainer identified this PR as the smaller partial change and stated that #2761 contained the full fix.
-
Likely Fixed By:
canonical/snapcraft#3579
(confidence 90%)
The Core20-base solution associated with #2761 was ultimately merged through this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4343 feat(remote-build): check base before executing | snapcraft | merged | Merged into main as commit 128e0acb2. Added base validation before remote-build, allowing fallback for core20/core22 while rejecting unsupported bases and fixing #4318. |