← Back to issue list

yaml_utils: move _load_yaml from project for re-use (and add tests)

View original Github issue

Metadata

Project
snapcraft
Number
#2781
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #2781 (commit 89bc9695c): moved YAML loading into yaml_utils as load_yaml_file, added tests in f1e9d4acf, and normalized YAML errors to YamlValidationError.

Resolution: closed resolved

Reason: PR #2781 was approved and merged, delivering the yaml_utils refactor and unit tests. Commit 89bc9695c moved _load_yaml, while f1e9d4acf added coverage for load_yaml_file and its error handling.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Rename to `load_yaml_file`. This version of load has the most complete error handling, converting the assortment of yaml errors into a YamlValidationError. We will re-use this logic for snapcraft's configuration file.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #2781 (commit 89bc9695c): moved YAML loading into yaml_utils as load_yaml_file, added tests in f1e9d4acf, and normalized YAML errors to YamlValidationError.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#2781: moved YAML loading into yaml_utils as load_yaml_file, added tests, and normalized YAML errors to YamlValidationError for reuse in Snapcraft config.
qwen/qwen3.6-35b-a3b — — Merged. Moved _load_yaml to yaml_utils as load_yaml_file, added tests, and improved error handling to raise YamlValidationError. Approved, passed CI, and changed 3 files. Logic will be reused for snapcraft config files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Moved load_yaml to yaml_utils, renamed to load_yaml_file, and added tests. Enhanced error handling converts YAML errors to YamlValidationError. Now available for reuse in snapcraft configuration files.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3385 yaml_utils: promote module to a package snapcraft merged Merged #3385 as commit 23059ae25, promoting yaml_utils to a package and moving YAML-specific error handling and its unit tests into snapcraft.yaml_utils.errors.
71%