← Back to issue list

cli: add support for 'http-proxy' and 'https-proxy' parameters

View original Github issue

Metadata

Project
snapcraft
Number
#2786
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged after review and conflict resolution. Adds CLI parameters for http_proxy and https_proxy to configure build environment variables. Refactored to a unified option set with provider-specific support for lxd, multipass, host, and managed-host.

Suggested action:

No scores available.

Issue body

Some modules support configuration of http(s) proxies today (e.g. ant, maven, nodejs) - but they are only honoured if building with host provider and the environment variables are already in the environment. Add two explicit build options for http_proxy and https_proxy, with matching environment variables to support typical application behavior. Only add these to the environment if provider is one of 'lxd', 'multipass', 'host', or 'managed-host'. Otherwise, either: (a) warn if found in the user's environment. (b) error if not found in environment, and therefor must have been configured with an explicit command-line option. Add tests for coverage of get_build_environment_flags() with new http_proxy and https_proxy handling.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after review and conflict resolution. Adds CLI parameters for http_proxy and https_proxy to configure build environment variables. Refactored to a unified option set with provider-specific support for lxd, multipass, host, and managed-host.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds explicit http-proxy and https-proxy CLI parameters to configure build environment variables for LXD, Multipass, and host providers. Refactored command execution and unified provider handling during review before final merge.
qwen3.6-35b-a3b-mtp-q6 Merged after conflict resolution and PR #2678 dependency. Introduces explicit http_proxy and https_proxy CLI parameters, refactored to a single options set with supported_providers to standardize environment variable injection across LXD, Multipass, and host providers.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2678 cli: introduce --provider snapcraft merged Merged into master. Adds a --provider CLI flag for host, lxd, and multipass, replacing legacy flags. Refactors option handling, cleans up configuration, and increases coverage. Approved and passed CI.
70%