← Back to issue list

snap: only ship .pyc files, strip shared objects

View original Github issue

Metadata

Project
snapcraft
Number
#2843
Type
pull request
State
closed
Author
om26er
Labels
—
Created
Updated
Closed

Current evaluation

PR #2843 (ship only .pyc, strip shared objects in the snap) was closed unmerged; maintainer sergiusens rejected it in May 2020 as "quite a controversial change" that does not fit the project's goals.

Resolution: closed stale

Reason: No code was merged: the PR sat with 4 unresolved review comments from December 2019 to January 2020 and was finally closed by sergiusens on 2020-05-18 with the comment that the change is controversial and "does not seem to fit our goals". Shipping .py sources alongside .pyc files remains intentional, consistent with the earlier decision in commit da6cab6c2 (snap: re-add pyc files, #2425).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [*] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [*] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [*] Have you successfully run `./runtests.sh static`? - [*] Have you successfully run `./runtests.sh tests/unit`? ----- To speed things up snapcraft ships .pyc files as part of its snap package, at the same times it also ships .py files. This is duplication and increases the size of the snap unneeded. This PR also strips shared objects that are bundled with snapcraft. The change reduces the download size of the snap by 15Mb

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #2843 (ship only .pyc, strip shared objects in the snap) was closed unmerged; maintainer sergiusens rejected it in May 2020 as "quite a controversial change" that does not fit the project's goals.
stealth/space-bunny-alpha — closed stale Rejected unmerged: maintainer @sergiusens said removing Python sources and stripping shared objects was too controversial and did not fit Snapcraft's goals.
stealth/space-bunny-alpha — closed not a bug Closed unmerged: maintainer sergiusens rejected omitting Python sources and stripping shared objects as controversial and contrary to Snapcraft's goals.
stealth/space-bunny-alpha — closed not a bug PR #2843 was closed unmerged: a maintainer rejected removing Python source and stripping shared objects as controversial and outside Snapcraft's goals, despite an estimated 15 MB size reduction.
qwen/qwen3.6-35b-a3b — — Rejected. The maintainer closed the request, noting that removing source .py files and stripping shared objects is controversial and conflicts with project goals, despite the 15MB size reduction.
qwen3.6-35b-a3b-mtp-q6 — — Rejected as controversial and misaligned with project goals. Maintainers declined removing .py source files to preserve debugging access, despite the 15MB size reduction from stripping shared objects and shipping only .pyc files.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2425 (confidence 60%)

    Earlier PR/commit da6cab6c2 re-added .pyc files to the snap, the opposite direction; shipping compiled+source Python in the snap is a deliberate project decision.

Related issues

No related issues found above the similarity threshold.