← Back to issue list

Close fd on invalid credentials for upload

View original Github issue

Metadata

Project
snapcraft
Number
#285
Type
pull request
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged as superseded by merged PR snapcraft#283, which already fixed the invalid-credentials file-descriptor leak.

Resolution: closed superseded

Reason: PR #283 was merged in commit 0c37853c4 with implementation commit d18b3f8e3. Maintainer @kyrofa noted that #283 already fixed the bug and included a refactor.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by merged PR snapcraft#283, which already fixed the invalid-credentials file-descriptor leak.
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by merged PR #283, which already fixed the invalid-credentials file-descriptor leak and included a refactor.
qwen/qwen3.6-35b-a3b — — Superseded by PR #283, which already fixed the bug and included a refactor. Reviewers approved the changes but noted the duplication, leading to closure.
qwen3.6-35b-a3b-mtp-q6 — — Superseded and closed. The underlying bug was already resolved in PR #283, which included a refactor, making this pull request unnecessary.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#283 (confidence 100%)

    Merged PR #283 already contained the file-descriptor fix.

  • Related To: snapcraft#284 (confidence 95%)

    The author identified merged PR #284 as a dependency.

Related issues

No related issues found above the similarity threshold.