← Back to issue list

Use ensure_dir_exists instead of mkdir -p

View original Github issue

Metadata

Project
snapcraft
Number
#2886
Type
pull request
State
merged
Author
MarcusTomlinson
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 2d438b318, replacing mkdir -p calls with ensure_dir_exists across three extension files to avoid unnecessary directory creation.

Resolution: closed resolved

Reason: PR #2886 was approved and merged as commit 2d438b318. The change uses ensure_dir_exists, which avoids invoking mkdir -p when the target directory already exists.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 2d438b318, replacing mkdir -p calls with ensure_dir_exists across three extension files to avoid unnecessary directory creation.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#2886 (commit 2d438b318), replacing mkdir -p with ensure_dir_exists across three files.
qwen/qwen3.6-35b-a3b — — Merged after replacing mkdir -p with ensure_dir_exists across three files. Approved by one reviewer and passed CI checks, standardizing directory creation logic.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaced mkdir -p with the ensure_dir_exists function to standardize directory creation. The contribution passed static and unit tests and was accepted without further review.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.