← Back to issue list

Add snapcraft plugin for Qt Build Suite (qbs)

View original Github issue

Metadata

Project
snapcraft
Number
#2892
Type
pull request
State
closed
Author
bjorn
Labels
Created
Updated
Closed

Current evaluation

Closed as stale. Maintainers requested converting integration tests to spread tests and fixing unit failures, but the author cited limited time and Python experience. The contribution was abandoned and never merged.

Suggested action:

No scores available.

Issue body

This plugin supports building any applications that use gcc or clang toolchains, as well as Qt(4&5) based applications. I've revived it from #1079, first start is just to cherry-pick the change that was reverted later and to resolve the conflicts. Then I ran `black .` to fix up the coding style and made some further changes to make static tests pass. LP: [#1659537](https://bugs.launchpad.net/snapcraft/+bug/1659537) - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? * Doesn't work yet (see output below) ----- `./runtests.sh static` outputs: ``` Running black All done! ✨ 🍰 ✨ 612 files would be left unchanged. Running flake8 Running mypy Running codespell ./tests/spread/plugins/rust/snaps/rust-workspace-fib/calc-fib/src/main.rs:2: crate ==> create, crate ./tests/spread/plugins/rust/snaps/rust-with-conditional/src/main.rs:1: crate ==> create, crate WARNING: Binary file: ./tests/spread/general/invalid-elf/snaps/invalid_elf/corrupt_empty.elf64.so WARNING: Binary file: ./tests/spread/general/invalid-elf/snaps/invalid_elf/corrupt_unicode.elf64.so ``` (seems unrelated to Qbs plugin, so assuming this is a successful run) `./runtests.sh tests/unit` outputs: ``` ====================================================================== FAIL: test_schema (tests.unit.plugins.test_qbs.QbsPluginTestCase) tests.unit.plugins.test_qbs.QbsPluginTestCase.test_schema ---------------------------------------------------------------------- testtools.testresult.real._StringException: Empty attachments: pythonlogging:'' Traceback (most recent call last): File "/home/ubuntu/snapcraft/tests/unit/plugins/test_qbs.py", line 149, in test_schema 'Expected schema to include "build-properties"', File "/home/ubuntu/.venv/snapcraft/lib/python3.6/site-packages/unittest2/case.py", line 702, in assertTrue raise self.failureException(msg) AssertionError: False is not true : Expected schema to include "build-properties" ```

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed as stale. Maintainers requested converting integration tests to spread tests and fixing unit failures, but the author cited limited time and Python experience. The contribution was abandoned and never merged.
qwen3.6-35b-a3b-mtp-q6 A Qbs plugin contribution required integration test conversions and code fixes. Maintainers requested updates, but the PR closed as stale after the author lacked time and Python experience to proceed, leaving it unmerged.
qwen3.6-35b-a3b-mtp-q6 Closed as stale. Maintainers requested CLA verification, formatting fixes, and converting integration tests to spread tests. The contributor lacked time and Python experience to proceed, abandoning the Qbs plugin addition.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1079 Add snapcraft plugin for Qt Build Suite (qbs) snapcraft merged Approved by two reviewers and merged into the main branch, this pull request introduces a snapcraft plugin for the Qt Build Suite (qbs). It enables building Qt4 and Qt5 applications using gcc or clang toolchains.
75%