elf: search for host libraries within search paths
Metadata
Current evaluation
Merged PR #2909 (commit 12f05b3e4) by sergiusens fixes an ELF host-library regression from 76e8a3f3: host-found absolute library paths no longer bypass the configured library search paths; unit test added.
Resolution: closed resolved
Reason: The PR itself was merged into master as commit 12f05b3e4 ("elf: search for host libraries within search paths (#2909)"), reversing the behaviour introduced by 76e8a3f3f1c3 and restoring os.path.join of the snapcraft search paths, with a regression unit test.
Evaluated by: mr-cal-bot
No scores available.
Issue body
A regression was introduced with commit 76e8a3f3f1c3f69d957b2806c9387ac3c57e926a
which considered elf files on the host system to be valid. Additionally, since
the host-found libraries were absolute paths, an os.path.join suffixing the
search paths snapcraft cared about were ignored.
A unit test which considers this scenario was added.
LP: #1860766
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2909 (commit 12f05b3e4) by sergiusens fixes an ELF host-library regression from 76e8a3f3: host-found absolute library paths no longer bypass the configured library search paths; unit test added. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed host ELF library path handling in merged PR #2909 (commit 12f05b3e4): host-found absolute paths no longer bypass configured search paths, with a regression test added. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed ELF host-library lookup regression: libraries now honor configured search paths instead of being accepted via absolute host paths. Added a regression unit test; merged as #2909 (12f05b3e4). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for a regression where host ELF libraries were incorrectly validated using absolute paths, bypassing snapcraft's configured search paths. Added a unit test. Resolves LP: #1860766. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for a regression where host ELF files were incorrectly validated, causing absolute paths to bypass snapcraft's library search paths. Includes a unit test and was merged into master. |
Update history
No update history recorded yet.
Related work
-
Caused By:
76e8a3f3f1c3f69d957b2806c9387ac3c57e926a
(confidence 90%)
Referenced in the PR body as the commit that introduced the regression by treating host ELF files as valid.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2746 elf: handle missing dependencies not found on system | snapcraft | merged | Merged PR #2746 via ed3f32aa3: ELF scanning now retains unresolved libraries, falls back to sonames, parses ldd output reliably, and tests missing-library cases. |