meta: do not prime commands with adapter == "none"
Metadata
Current evaluation
Merged fix ensuring Snapcraft passes commands through unmodified when adapter is set to none, aligning with wrapper and snapcraft-runner behavior. Includes unit and spread test updates. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
Snapcraft is priming (modifying) the commands when adapter is set
to "none". These commands should be passed through as-is and never
modify them. This will be consistent with snapcraft's behavior with
regards to wrappers and snapcraft-runner (it does not generate wrappers
or modify the command-chain).
Add unit test for "none" case and update adapter spread test to
include a case for a adapter "none" with a python script command.
LP #1862163
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix ensuring Snapcraft passes commands through unmodified when adapter is set to none, aligning with wrapper and snapcraft-runner behavior. Includes unit and spread test updates. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix ensuring Snapcraft passes commands through unmodified when adapter is set to none, aligning with wrapper and snapcraft-runner behavior. Includes updated unit and spread tests. Resolves LP #1862163. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix preventing Snapcraft from modifying commands when adapter is none. Commands now pass through unmodified, matching wrapper behavior. Includes updated unit and spread tests. Resolves LP #1862163. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2853 meta: do not set snapcraft-runner when adapter is "none" | snapcraft | merged | Merged fix ensuring snapcraft honors the 'none' adapter setting by omitting the snapcraft-runner command-chain. Previously, the runner was incorrectly injected regardless of adapter configuration. Approved and merged with accompanying spread tests. | |
| #1955 meta: make sure adapter does not propagate | snapcraft | merged | Merged to prevent the adapter property from propagating from snapcraft.yaml to snap.yaml, resolving Launchpad bug #1750658. Approved by two reviewers, passed CI, and applied with 26 additions and 2 deletions across two files. | |
| #2864 meta: assume command-chain fix for prepending snapcraft-runner | snapcraft | merged | Merged a fix adding a missing check for prepend_command_chain when determining if command-chain should be assumed in metadata. Includes updated assumes coverage tests. Approved by one reviewer and passed CI checks. |