meta: do not prime commands with adapter == "none"
Metadata
Current evaluation
Merged PR #2912 (commit f9475e6f1) preserved commands unchanged when adapter is "none" and added unit and spread coverage for none and Python-script cases.
Resolution: closed resolved
Reason: PR #2912 was merged into Snapcraft as commit f9475e6f1, fixing command priming so adapter "none" passes commands through unchanged.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Snapcraft is priming (modifying) the commands when adapter is set
to "none". These commands should be passed through as-is and never
modify them. This will be consistent with snapcraft's behavior with
regards to wrappers and snapcraft-runner (it does not generate wrappers
or modify the command-chain).
Add unit test for "none" case and update adapter spread test to
include a case for a adapter "none" with a python script command.
LP #1862163
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2912 (commit f9475e6f1) preserved commands unchanged when adapter is "none" and added unit and spread coverage for none and Python-script cases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#2912 (f9475e6f1), preserving commands unchanged for adapter "none" and adding unit and spread-test coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2912 (commit f9475e6f1) stops Snapcraft from modifying/priming commands when the part adapter is "none", matching wrapper/snapcraft-runner behaviour; adds unit test plus spread coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2912 (commit f9475e6f1) stops Snapcraft from modifying commands when adapter is "none"; unit and spread tests cover none and Python-script cases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2912 (f9475e6f1): commands using adapter "none" now pass through unchanged, with unit and adapter-spread test coverage added. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix ensuring Snapcraft passes commands through unmodified when adapter is set to none, aligning with wrapper and snapcraft-runner behavior. Includes unit and spread test updates. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix ensuring Snapcraft passes commands through unmodified when adapter is set to none, aligning with wrapper and snapcraft-runner behavior. Includes updated unit and spread tests. Resolves LP #1862163. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.