meta: ensure Application passthrough is scrubbed for snap.yaml
Metadata
Current evaluation
Merged PR #2914 fixed snap.yaml generation to scrub Application passthrough metadata; commit da9508fd3 added unit and spread coverage.
Resolution: closed resolved
Reason: PR #2914 was merged as commit da9508fd3. It removes Application passthrough from the data used to generate snap.yaml and adds regression coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The original `passthrough` was leaking through into the snap.yaml
from the app_dict. Ensure "passthrough" is popped from the dict
used to create the snap.yaml.
Add unit tests for passthrough coverage of Application.
LP #1862197
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2914 fixed snap.yaml generation to scrub Application passthrough metadata; commit da9508fd3 added unit and spread coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged to snapcraft master as da9508fd3. Popped "passthrough" from the app dict before building snap.yaml, so Application passthrough no longer leaks verbatim; added unit tests plus spread coverage for apps, hooks and snaps (LP #1862197). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2914 in commit da9508fd3, removing Application passthrough metadata from generated snap.yaml and adding passthrough unit-test coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for application passthrough leaking into snap.yaml. The change removes the field from the app dictionary before generation and adds unit and spread tests. Resolves LP #1862197. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing passthrough leakage into snap.yaml by removing the field from the application dictionary before generation. Added unit and spread tests for Application, hooks, and snap passthrough. Resolves LP #1862197. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1862197 passthrough field being added to snap.yaml | snapcraft (launchpad) | closed | App-level `passthrough` keys were copied verbatim into the generated meta/snap.yaml, triggering manual review on store builds. Fixed by merged PR snapcore/snapcraft#2914 (commit da9508fd3), released in snapcraft 3.10; passthrough is now dropped from snap.yaml. | |
| #2053 meta: implement pass-through of properties to snap.yaml | snapcraft | merged | Merged #2053 as f9b75a974, adding global and app-local passthrough metadata, ambiguity checks, and warnings for unvalidated snap.yaml properties. |