remote-build: pass through 'source-subdir' property
Metadata
Current evaluation
Merged. Fixes remote-build incorrectly stripping the 'source-subdir' property by passing it through. Includes test coverage for source property handling. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
It is currently being stripped with the other source keys,
but we need to instead pass it through.
Add a test to verify source properties are passed through (or not).
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Fixes remote-build incorrectly stripping the 'source-subdir' property by passing it through. Includes test coverage for source property handling. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Remote builds now correctly pass through the source-subdir property instead of stripping it. A test verifies source property handling. Changes achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to pass through the source-subdir property during remote builds instead of stripping it. Includes a test verifying source property handling. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2634 remote build: fully preserve local sources and support packaging all sources | snapcraft | merged | Merged into remote-build. Preserves local sources and enables packaging all sources. Modified 13 files (+673/-528). Iterative updates addressed review feedback, fixed tests, resolved Git import issues, and updated dependencies. Approved by one reviewer. | |
| #3056 remote-build: package up local sources with source-type 'git' | snapcraft | merged | Merged after approval. Implements remote-build packaging for local sources with source-type 'git'. Approved by one reviewer with zero unresolved comments. Changes modify 2 files (+10/-3 lines). |